From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How about making `set-minibuffer-window' obsolete? Date: Thu, 18 Mar 2021 14:01:36 +0200 Message-ID: <83r1kcbrhb.fsf@gnu.org> References: <838s6ndjon.fsf@gnu.org> <83y2emc500.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 18 13:03:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMrNU-0007N3-TM for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Mar 2021 13:03:48 +0100 Original-Received: from localhost ([::1]:53328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMrNT-0001Mu-TI for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Mar 2021 08:03:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMrLP-00081s-Gi for emacs-devel@gnu.org; Thu, 18 Mar 2021 08:01:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53555) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMrLO-0003ed-MR; Thu, 18 Mar 2021 08:01:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1691 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMrLN-0001oU-Iz; Thu, 18 Mar 2021 08:01:38 -0400 In-Reply-To: (message from Alan Mackenzie on Thu, 18 Mar 2021 11:46:57 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266562 Archived-At: > Date: Thu, 18 Mar 2021 11:46:57 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > > I don't think I agree, not in this general form anyway. The C code > > assigns values to minibuf_window in several places; this function is > > the Lisp counterpart of that. If the C code can assign that variable, > > why cannot Lisp code do the same if it needs to? > > The C code does it only under very carefully controlled circumstances > (such as when iconising a frame). If that's the real problem, then let's document that this function can be dangerous and should only be used with extreme care. > > > Could I ask you, please, to reconsider? > > > I might -- if I see some specific reasoning. I didn't see that yet. > > OK. set-minibuffer-window, as it stands, has no function. Maybe as an > alternative to obsoleting it, we could give it functionality - the > function could move an open minibuffer from one frame to another frame, > for example. But I'm not sure what the use case is. All the > minibuffer-follows-selected-frame stuff is done internally in minibuf.c. Martin suggested adding functionality, and I'm okay with doing that.