From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Date: Thu, 25 Mar 2021 19:00:32 +0200 Message-ID: <83r1k3qibz.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38353"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@catern.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 18:07:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPTRj-0009oS-N6 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 18:06:59 +0100 Original-Received: from localhost ([::1]:38386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPTRi-0005oA-NG for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 13:06:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPTLb-0000rd-Gj for emacs-devel@gnu.org; Thu, 25 Mar 2021 13:00:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55343) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPTLa-0002s8-Ng; Thu, 25 Mar 2021 13:00:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4595 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lPTLV-0004SI-KY; Thu, 25 Mar 2021 13:00:35 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 25 Mar 2021 12:48:53 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267037 Archived-At: > From: Stefan Monnier > Cc: Spencer Baugh , emacs-devel@gnu.org > Date: Thu, 25 Mar 2021 12:48:53 -0400 > > > I'd prefer to pick up where we left off back then. The main issue > > left unresolved in the past discussion was the potential slowdown of > > simple accesses to buffer-local vars due to your proposal. Can we > > please have benchmarks for that, so we could decide whether the > > tradeoff is worth it? It's quite possible that the performance > > aspects could affect the code changes, so even uncontroversial > > cleanups should perhaps wait until we have figured out the more > > important aspects of these changesets. > > I think those changes are good to go and fundamentally unrelated to > the discussion (except to the extent that they were found while > investigating that part of the code). > > Of course, they may not be the final word, but I'd rather install those > now so they don't get lost if the rest of the discussion ends up not > going anywhere and also so the rest of the discussion doesn't need to be > using patches relative to code that's not in `master`. Sorry, no. I don't want to make minor cleanups unless they are related to a useful development. Those cleanups are more trouble than they are worth (excluding the additions to the test suite, of course). Nothing of value will be lost if they are lost.