From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making `x-underline-at-descent-line' a face attribute Date: Tue, 11 Jan 2022 18:46:11 +0200 Message-ID: <83r19e6x0s.fsf@gnu.org> References: <87lezt5v7h.fsf.ref@yahoo.com> <87lezt5v7h.fsf@yahoo.com> <83r19l8d94.fsf@gnu.org> <87wnjd434b.fsf@yahoo.com> <83ee5l8433.fsf@gnu.org> <877dbd3vdk.fsf@yahoo.com> <8335m17z17.fsf@gnu.org> <87tueg1iei.fsf@yahoo.com> <83zgo858a2.fsf@gnu.org> <871r1kyq3e.fsf@yahoo.com> <83mtk854rt.fsf@gnu.org> <877dbbyffx.fsf@yahoo.com> <87mtk5viuy.fsf@yahoo.com> <878rvnrhcf.fsf@yahoo.com> <834k6ba3pu.fsf@gnu.org> <877db7p07t.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 17:51:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7KMc-000AeE-FF for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 17:51:14 +0100 Original-Received: from localhost ([::1]:41714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7KMa-0003Vl-JC for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 11:51:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KHq-0001Dc-0m for emacs-devel@gnu.org; Tue, 11 Jan 2022 11:46:18 -0500 Original-Received: from [2001:470:142:3::e] (port=51464 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KHp-0003Nk-NO; Tue, 11 Jan 2022 11:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=e84N2OLkqHrMIguFFDPeq46Ysk9HHLTnmTuyztigeLE=; b=OqGVuq5bhbah VxDjIFgUCRT9CQjSZm/Uw4/k2WhVjjAnn1J5XMm0RiktJfBlUQsW+yeO4YAMjj4eBYYx+IFw9pRGA t/rsArYlJEXLpKi6UTrzORv0Ch+t/STdC6TrIR8VxBpxZoET3tzM8xCc8V2uRyRKWsOJUB3X+rJvP yjt0W+slf6THe1iRAIDu1q0ncsn4xiXT0xktMral69qfy40nagfAsQG/IUQThn6g9Oo0yNExcMDCR 5uBYHZj+/WqPc6ERKUA47blB8ptC3vZVLKcrfTFo5+SexBtRvxjdbe3t38JXiCQbUFSBDk6/Ykiw9 cqaR2Asn56eQrNQAfwnKIQ==; Original-Received: from [87.69.77.57] (port=3533 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KHp-00089R-OG; Tue, 11 Jan 2022 11:46:18 -0500 In-Reply-To: <877db7p07t.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jan 2022 08:47:34 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284615 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Tue, 11 Jan 2022 08:47:34 +0800 > > Eli Zaretskii writes: > > > Can you post some tests to run and see if it works OK? > > Here you go: > > ;; Underline should appear at 3 pixels above the descent line. > (set-face-attribute 'default nil :underline '(:position 3)) > > ;; Underline should appear at the descent line. > (set-face-attribute 'default nil :underline '(:position 0)) > > ;; Underline should appear at the descent line. > (set-face-attribute 'default nil :underline '(:position t)) > > ;; Underline should appear at the default location determined by > ;; x-use-underline-position-properties. > (set-face-attribute 'default nil :underline '(:position nil)) The last one signals an error: Debugger entered--Lisp error: (error "Invalid face underline" :position nil) internal-set-lisp-face-attribute(default :underline (:position nil) 0) set-face-attribute(default nil :underline (:position nil)) eval((set-face-attribute 'default nil :underline '(:position nil)) t) eval-expression((set-face-attribute 'default nil :underline '(:position nil)) nil nil 127) funcall-interactively(eval-expression (set-face-attribute 'default nil :underline '(:position nil)) nil nil 127) call-interactively(eval-expression nil nil) command-execute(eval-expression) The rest seem to work correctly.