From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Making `x-underline-at-descent-line' a face attribute
Date: Tue, 11 Jan 2022 18:46:11 +0200 [thread overview]
Message-ID: <83r19e6x0s.fsf@gnu.org> (raw)
In-Reply-To: <877db7p07t.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jan 2022 08:47:34 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 11 Jan 2022 08:47:34 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Can you post some tests to run and see if it works OK?
>
> Here you go:
>
> ;; Underline should appear at 3 pixels above the descent line.
> (set-face-attribute 'default nil :underline '(:position 3))
>
> ;; Underline should appear at the descent line.
> (set-face-attribute 'default nil :underline '(:position 0))
>
> ;; Underline should appear at the descent line.
> (set-face-attribute 'default nil :underline '(:position t))
>
> ;; Underline should appear at the default location determined by
> ;; x-use-underline-position-properties.
> (set-face-attribute 'default nil :underline '(:position nil))
The last one signals an error:
Debugger entered--Lisp error: (error "Invalid face underline" :position nil)
internal-set-lisp-face-attribute(default :underline (:position nil) 0)
set-face-attribute(default nil :underline (:position nil))
eval((set-face-attribute 'default nil :underline '(:position nil)) t)
eval-expression((set-face-attribute 'default nil :underline '(:position nil)) nil nil 127)
funcall-interactively(eval-expression (set-face-attribute 'default nil :underline '(:position nil)) nil nil 127)
call-interactively(eval-expression nil nil)
command-execute(eval-expression)
The rest seem to work correctly.
next prev parent reply other threads:[~2022-01-11 16:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87lezt5v7h.fsf.ref@yahoo.com>
2022-01-06 4:44 ` Making `x-underline-at-descent-line' a face attribute Po Lu
2022-01-06 5:08 ` Jim Porter
2022-01-06 5:35 ` Po Lu
2022-01-06 8:47 ` Eli Zaretskii
2022-01-06 8:43 ` Eli Zaretskii
2022-01-06 17:47 ` Jim Porter
2022-01-06 20:07 ` Eli Zaretskii
2022-01-06 20:18 ` Juri Linkov
2022-01-07 0:55 ` Po Lu
2022-01-07 7:17 ` Eli Zaretskii
2022-01-07 8:40 ` Juri Linkov
2022-01-07 9:40 ` Stefan Kangas
2022-01-08 18:20 ` Juri Linkov
2022-01-08 18:52 ` Eli Zaretskii
2022-01-08 19:09 ` Juri Linkov
2022-01-08 19:14 ` Eli Zaretskii
2022-01-07 13:14 ` Eli Zaretskii
2022-01-07 13:32 ` martin rudalics
2022-01-08 18:23 ` Juri Linkov
2022-01-08 18:39 ` Eli Zaretskii
2022-01-06 20:49 ` Jim Porter
2022-01-07 6:43 ` Eli Zaretskii
2022-01-06 8:44 ` Eli Zaretskii
2022-01-06 9:36 ` Po Lu
2022-01-06 12:02 ` Eli Zaretskii
2022-01-06 12:24 ` Po Lu
2022-01-06 13:51 ` Eli Zaretskii
2022-01-07 0:47 ` Po Lu
2022-01-07 7:12 ` Eli Zaretskii
2022-01-07 7:14 ` Po Lu
2022-01-07 8:28 ` Eli Zaretskii
2022-01-07 11:04 ` Po Lu
2022-01-07 12:21 ` Eli Zaretskii
2022-01-07 12:33 ` Po Lu
2022-01-07 12:41 ` Eli Zaretskii
2022-01-09 0:43 ` Po Lu
2022-01-10 10:54 ` Po Lu
2022-01-10 11:32 ` Po Lu
2022-01-10 17:41 ` Eli Zaretskii
2022-01-11 0:47 ` Po Lu
2022-01-11 16:46 ` Eli Zaretskii [this message]
2022-01-06 8:48 ` Lars Ingebrigtsen
2022-01-06 9:38 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r19e6x0s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).