From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: process-file instead of call-process in proced.el? Date: Fri, 25 Mar 2022 15:12:13 +0300 Message-ID: <83r16qb59e.fsf@gnu.org> References: <835yo2cyj9.fsf@gnu.org> <83v8w2b9wn.fsf@gnu.org> <87tubmi7b5.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: fgunbin@fastmail.fm, winkler@gnu.org, emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 25 13:14:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXipf-0006eB-Ta for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Mar 2022 13:14:19 +0100 Original-Received: from localhost ([::1]:59620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXipe-00019t-DT for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Mar 2022 08:14:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXinn-0007VQ-Ki for emacs-devel@gnu.org; Fri, 25 Mar 2022 08:12:23 -0400 Original-Received: from [2001:470:142:3::e] (port=59786 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXinn-0006DL-3f; Fri, 25 Mar 2022 08:12:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XkNcEtuqZBew2ygn3nZSjxb0RkRc/8vysBMrIM/CFGM=; b=I7cIgfJBt+vC h1T3bXwrghC4iWTQGguAskIepis3yU6JNnk1NRrJE5VcVpBrjiAnptfgHuoVL3V5O7LM79/s+GzOd LgwUK+sSdV4a4GluNAAMMnwFUh76KUqT0XKJJ1/ZXqoN0mSn8IGc6Vw+0YetTPNV8SAQfRvDTgK4o NavMTnT3hbp49lUIM774I/8OOZ8XJR2Xzh8Yiy3pWJyu+jQ6nUSQ23GKgN47V90mSD5MOkdBO9uqg x6cpyIx8rPIT3+y5QNjs1mtILE8+mSvDjQQA61mtdsEgXa0HgPORk8oVEXKYHY4BbAfMKQeYe2hzd Yj5V3JxcDf+v5P4SgCFD6w==; Original-Received: from [87.69.77.57] (port=4851 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXinj-0004WB-NO; Fri, 25 Mar 2022 08:12:22 -0400 In-Reply-To: <87tubmi7b5.fsf@gmx.de> (message from Michael Albinus on Fri, 25 Mar 2022 12:46:06 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287446 Archived-At: > From: Michael Albinus > Cc: Filipp Gunbin , winkler@gnu.org, emacs-devel@gnu.org > Date: Fri, 25 Mar 2022 12:46:06 +0100 > > Eli Zaretskii writes: > > >> The patch only changes call-process to process-file, to support file > >> handlers. Setting "kill" into proced-signal-function is a user > >> customization. > > > > Sorry, from my POV fixing something means making it work as correctly > > as we can reasonably do. If it didn't work correctly before, we > > should fix that as well, as part of any work on the relevant code. I > > understand that, if the doing TRT is complicated, it could be left to > > a separate patch, but in this case it isn't complicated at all. > > > > So let's fix this part of proced to work on all supported platforms, > > okay? > > I don't understand why an external "kill" process is applied. Couldn't > we simply call always `signal-process'? A comment in > `proced-send-signal' recommends this already. > > Then we could give `signal-process' a handler, like `interrupt-process' > has already. (Well, we would need a mean to indicate, that a process-id > is meant for a remote host.) Yes, that'd be much better, IMO.