Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat'

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 19 Apr 2022 05:19:10 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: Mattias Engdegård <mattiase@acm.org>,
>  Keith David Bershatsky <esq@lawlist.com>, Paul Eggert <eggert@cs.ucla.edu>,
>  emacs-devel@gnu.org
> 
> >   NSDictionary *font_attribs = @{NSFontAttributeName: menuFont};
> 
> Welcome to the wonderful world of Objective C under GCC.
> 
> The attached should fix this particular error.
> 
> These problems will need to be fixed in the emacs-28 branch, assuming
> we're going to continue supporting macOS 10.6.

Since this affects only the macOS builds, if you consider these
changes safe enough for the release branch, I don't object to
installing this there.  But please take into account that there are
several other issues with that old version, and the changes proposed
for them would affect platforms other than macOS, and some of them are
on very low level, and so cannot be installed on the release branch at
this time.  Which means that a build of Emacs 28 on those old macOS
platforms will probably not work without manual patching anyway.

> FWIW, I've moved away from trying to hide warnings generated on older
> versions of macOS to try and avoid the difficult to understand #if
> constructions we've previously used throughout the code.

I agree.  We do the same for other old platforms.