From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, eggert@cs.ucla.edu
Subject: Re: master afc0bfd380: Speed up loaddefs-generate on slow disks
Date: Thu, 02 Jun 2022 19:16:00 +0300 [thread overview]
Message-ID: <83r147dosf.fsf@gnu.org> (raw)
In-Reply-To: <87a6avccs4.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 02 Jun 2022 17:20:43 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 02 Jun 2022 17:20:43 +0200
>
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
> > I'm really surprised this is faster, even on slow disks.
> > Does anyone have a idea of why that is?
Isn't that clear? file-newer-than-file-p calls 'stat' for both files,
and one of them is a loop invariant AFAIU. Taking its time outside
the loop speeds up things (but perhaps not on GNU/Linux).
> I didn't actually benchmark it -- either way is fast on my laptop. But
> the old autoloads code did it with time-less-p, and Eli said that it was
> faster, so... Perhaps Eli can report back whether it made a difference
> or not.
It did -- for the better. Thanks.
next prev parent reply other threads:[~2022-06-02 16:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165416120601.23485.9799765950267646757@vcs2.savannah.gnu.org>
[not found] ` <20220602091326.514E9C009A8@vcs2.savannah.gnu.org>
2022-06-02 15:10 ` master afc0bfd380: Speed up loaddefs-generate on slow disks Stefan Monnier
2022-06-02 15:20 ` Lars Ingebrigtsen
2022-06-02 16:16 ` Eli Zaretskii [this message]
2022-06-03 1:18 ` Stefan Monnier
2022-06-03 5:52 ` Eli Zaretskii
2022-06-03 12:21 ` Stefan Monnier
2022-06-03 13:05 ` Eli Zaretskii
2022-06-03 13:09 ` Stefan Monnier
2022-06-03 13:37 ` Eli Zaretskii
2022-06-04 12:30 ` Lars Ingebrigtsen
2022-06-05 10:06 ` Mattias Engdegård
2022-06-05 14:08 ` Lars Ingebrigtsen
2022-06-06 11:26 ` Lars Ingebrigtsen
2022-06-06 12:01 ` Alan Mackenzie
2022-06-06 12:05 ` Lars Ingebrigtsen
2022-06-06 12:08 ` Lars Ingebrigtsen
2022-06-06 12:16 ` Mattias Engdegård
2022-06-06 12:32 ` Lars Ingebrigtsen
2022-06-08 11:01 ` Lars Ingebrigtsen
2022-06-06 12:18 ` Andreas Schwab
2022-06-06 12:28 ` Lars Ingebrigtsen
2022-06-04 13:01 ` Lars Ingebrigtsen
2022-06-02 16:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r147dosf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).