From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 63d084d4e4: Fix encoding and decoding of process I/O in Eshell on Windows Date: Mon, 17 Oct 2022 19:14:13 +0300 Message-ID: <83r0z61l7u.fsf@gnu.org> References: <166583166191.28035.1408947255493373295@vcs2.savannah.gnu.org> <20221015110102.361A6C1AB48@vcs2.savannah.gnu.org> <875ygiy0is.fsf@gmail.com> <83tu421oka.fsf@gnu.org> <87y1tewkms.fsf@gmail.com> <83sfjm1mrz.fsf@gnu.org> <87pmeqwi4f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 17 18:16:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okSnL-0009Bs-MB for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Oct 2022 18:16:51 +0200 Original-Received: from localhost ([::1]:59850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okSnK-0006G0-6O for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Oct 2022 12:16:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okSlD-0005II-UV for emacs-devel@gnu.org; Mon, 17 Oct 2022 12:14:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okSlD-0005Vn-Lr; Mon, 17 Oct 2022 12:14:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VPnCwdp8exLTavuOcFX8nGtGfX5s8ImO7ytrHpIVD3s=; b=hr0sAh5rQ2Y5paXj0sXn odzExhGbXaLkl3UiIbM+uVixoOdUHiPA3UzbcWNBjs7x3ICWOPkdcgx+otAOkWERBlLxwjeC7dZMA ODxUM0ePIRK/AXs6GI4C/PNqbw2oPCH5l/qYUJ/RRuRPSkLM6XfyNTFO5FGDYIiP+YHiTKI7o7RKY SEQXiWwYzIRaTlaVuFLM4lE5lw76PioQ9vJiZMcXsrGWDxrqKaGkK/uV5kHHiXA6tql30J7RVfdOt opVtWBkyKwHm+e+PjCZdBv2li29pGNpymljKMpCR5JvZFvw5bLd51dlc/LVDp6zWfq3HjmCJRN0OO sA2Ii0qUnhD7kw==; Original-Received: from [87.69.77.57] (port=3225 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okSkz-0003U7-Q8; Mon, 17 Oct 2022 12:14:38 -0400 In-Reply-To: <87pmeqwi4f.fsf@gmail.com> (message from Robert Pluim on Mon, 17 Oct 2022 18:05:20 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297964 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Mon, 17 Oct 2022 18:05:20 +0200 > > Eli> Now let me turn the table and ask you why is :coding preferred, in > Eli> your opinion? > > Because weʼve had bugs where coding-system-for-read/write was used, > and processes created further down the call chain would use it, and by > the time they did its value had changed, which would have been avoided > by using :coding (I seem to remember an issue with an invocation of > gpg, although I wouldnʼt be surprised if there was some asynchronicity > involved as well) But that's in no way a general preference, just a practical consideration. And the kind of problems you mention don't exist in this case.