unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 63d084d4e4: Fix encoding and decoding of process I/O in Eshell on Windows
Date: Mon, 17 Oct 2022 19:14:13 +0300	[thread overview]
Message-ID: <83r0z61l7u.fsf@gnu.org> (raw)
In-Reply-To: <87pmeqwi4f.fsf@gmail.com> (message from Robert Pluim on Mon, 17 Oct 2022 18:05:20 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 17 Oct 2022 18:05:20 +0200
> 
>     Eli> Now let me turn the table and ask you why is :coding preferred, in
>     Eli> your opinion?
> 
> Because weʼve had bugs where coding-system-for-read/write was used,
> and processes created further down the call chain would use it, and by
> the time they did its value had changed, which would have been avoided
> by using :coding (I seem to remember an issue with an invocation of
> gpg, although I wouldnʼt be surprised if there was some asynchronicity
> involved as well)

But that's in no way a general preference, just a practical
consideration.  And the kind of problems you mention don't exist in
this case.



      reply	other threads:[~2022-10-17 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166583166191.28035.1408947255493373295@vcs2.savannah.gnu.org>
     [not found] ` <20221015110102.361A6C1AB48@vcs2.savannah.gnu.org>
2022-10-17 14:42   ` master 63d084d4e4: Fix encoding and decoding of process I/O in Eshell on Windows Robert Pluim
2022-10-17 15:01     ` Eli Zaretskii
2022-10-17 15:11       ` Robert Pluim
2022-10-17 15:40         ` Eli Zaretskii
2022-10-17 16:05           ` Robert Pluim
2022-10-17 16:14             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0z61l7u.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).