From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Date: Sat, 06 May 2023 16:27:41 +0300 Message-ID: <83r0rtfv3m.fsf@gnu.org> References: <874jorc7q2.fsf@betli.tmit.bme.hu> <83h6sqj4ed.fsf@gnu.org> <87354auafu.fsf@gmail.com> <835y96j10l.fsf@gnu.org> <87y1m2spbd.fsf@gmail.com> <87pm7dbo41.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40898"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 06 15:27:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvHwP-000AVe-C6 for ged-emacs-devel@m.gmane-mx.org; Sat, 06 May 2023 15:27:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvHvz-00024d-WC; Sat, 06 May 2023 09:26:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHvy-00024C-KV for emacs-devel@gnu.org; Sat, 06 May 2023 09:26:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHvy-00069S-3j; Sat, 06 May 2023 09:26:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tHCb/6IJbTHX7I0qDLUB1dp1xXH9jfn7SKb2mYHfFeI=; b=T9fnkUuMMuvmYlHV+t9B HA0dYW5/WFk3KCgjYbcAHkm/G40ondfFD62rnfHA/aI9tAbEfzfscpo0gVA22X6BVFAACMgWWXd6D 0zc2B12quJQK0V4kLuIgz+N+gDgPynczi/DGQ+nqhDxj5d5FUMrzZi1pI7aokzHdP+sutQrSE0q8t 3fYrKPFioXTMslX1xNQbTuxQmDpNraSQYZGb6avA252RlBm1Ial327rPzK/iwkbk//pIbk8m0mYSm H0OnhsiLMLkUIpNnQm7afgmrJTSTmQfSSQlXzwjyRX2f0H1zzeQfaMPWtKA8C0Gwf963HSCYmEj3f xIx3tMu+FyLNeg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHvx-0000PR-I6; Sat, 06 May 2023 09:26:45 -0400 In-Reply-To: <87pm7dbo41.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Sat, 06 May 2023 15:12:14 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305903 Archived-At: > From: Felician Nemeth > Cc: João Távora , > emacs-devel@gnu.org > Date: Sat, 06 May 2023 15:12:14 +0200 > > I can surely try to submit these extension one-by-one as patches to > Eglot, but my first attempt was friendly rejected, so I think a package > collecting these rejected extension is a good thing. Also, even my > patches implementing standard LSP features take a long time to be > processed, so temporarily collecting some extensions in the eglot-x > package allows me to work in my own pace. Since Eglot is now part of Emacs, the situation has changed. IMO, it is no longer reasonable to have extensions that cannot be possibly supported by the version of Eglot that comes with Emacs. IOW, if someone wants to download and install your extensions, we should try not to force them to also download and install a newer version of Eglot from ELPA. I hope this is possible. > Sometime ago, I collected the internal variables, functions, and advised > functions that eglot-x uses from Eglot in order to help to refine > Eglot's public API: > > https://github.com/joaotavora/eglot/discussions/802#discussioncomment-2171239 > > If it helps, I can explain one by one why it was necessary to use them. What mechanisms aside of advice can be used to extend Eglot so that it could optionally support those extensions?