unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: joaotavora@gmail.com, emacs-devel@gnu.org
Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot
Date: Sat, 06 May 2023 16:27:41 +0300	[thread overview]
Message-ID: <83r0rtfv3m.fsf@gnu.org> (raw)
In-Reply-To: <87pm7dbo41.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Sat, 06 May 2023 15:12:14 +0200)

> From: Felician Nemeth <felician.nemeth@gmail.com>
> Cc: João Távora <joaotavora@gmail.com>,
>   emacs-devel@gnu.org
> Date: Sat, 06 May 2023 15:12:14 +0200
> 
> I can surely try to submit these extension one-by-one as patches to
> Eglot, but my first attempt was friendly rejected, so I think a package
> collecting these rejected extension is a good thing.  Also, even my
> patches implementing standard LSP features take a long time to be
> processed, so temporarily collecting some extensions in the eglot-x
> package allows me to work in my own pace.

Since Eglot is now part of Emacs, the situation has changed.  IMO, it
is no longer reasonable to have extensions that cannot be possibly
supported by the version of Eglot that comes with Emacs.  IOW, if
someone wants to download and install your extensions, we should try
not to force them to also download and install a newer version of
Eglot from ELPA.  I hope this is possible.

> Sometime ago, I collected the internal variables, functions, and advised
> functions that eglot-x uses from Eglot in order to help to refine
> Eglot's public API:
> 
>   https://github.com/joaotavora/eglot/discussions/802#discussioncomment-2171239
> 
> If it helps, I can explain one by one why it was necessary to use them.

What mechanisms aside of advice can be used to extend Eglot so that it
could optionally support those extensions?



  reply	other threads:[~2023-05-06 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 11:56 [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Felician Nemeth
2023-05-05 13:18 ` Ruijie Yu via Emacs development discussions.
2023-05-06 13:14   ` Felician Nemeth
2023-05-05 13:26 ` Eli Zaretskii
2023-05-05 14:20   ` João Távora
2023-05-05 14:39     ` Eli Zaretskii
2023-05-05 16:41       ` João Távora
2023-05-06 13:12         ` Felician Nemeth
2023-05-06 13:27           ` Eli Zaretskii [this message]
2023-05-06 15:17             ` Felician Nemeth
2023-05-06 15:27               ` Eli Zaretskii
2023-05-06 13:51           ` João Távora
2023-05-06 15:28             ` Felician Nemeth
2023-05-05 16:38   ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0rtfv3m.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).