unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Arash Esbati <arash@gnu.org>
Cc: emacs-devel@gnu.org, juri@linkov.net
Subject: Re: master b8d4242e8bd 1/2: New user option 'shell-command-guess-functions' (bug#18132)
Date: Thu, 30 Nov 2023 08:08:16 +0200	[thread overview]
Message-ID: <83r0k76aen.fsf@gnu.org> (raw)
In-Reply-To: <m2r0k8z80h.fsf@macmutant.fritz.box> (message from Arash Esbati on Wed, 29 Nov 2023 20:14:54 +0100)

> From: Arash Esbati <arash@gnu.org>
> Cc: Juri Linkov <juri@linkov.net>
> Date: Wed, 29 Nov 2023 20:14:54 +0100
> 
> Juri Linkov <juri@jurta.org> writes:
> 
> >  (defun minibuffer-default-add-shell-commands ()
> >    "Return a list of all commands associated with the current file.
> > -This function is used to add all related commands retrieved by `mailcap'
> > -to the end of the list of defaults just after the default value."
> > -  (interactive)
> > +This function is used to add all related commands retrieved by
> > +`shell-command-guess' to the end of the list of defaults just
> > +after the default value."
> >    (let* ((filename (if (listp minibuffer-default)
> >  		       (car minibuffer-default)
> >  		     minibuffer-default))
> > -	 (commands (and filename (require 'mailcap nil t)
> > -			(mailcap-file-default-commands (list filename)))))
> > +	 (commands (and filename (shell-command-guess (list filename)))))
> >      (setq commands (mapcar (lambda (command)
> >  			     (concat command " " filename))
> >  			   commands))
> 
> This give me:
> 
>   ELC+ELN  ../lisp/simple.elc
> In end of data:
> simple.el:4286:35: Warning: the function ‘shell-command-guess’ is not
> known to be defined.
> 
> Maybe you want to declare that function?  This is with Emacs 30
> (a811846879) on macOS.

Same as previously: recompile once more, and the warning will be gone.

There's no problem here.



  reply	other threads:[~2023-11-30  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170110663333.10282.3772392230229139487@vcs2.savannah.gnu.org>
     [not found] ` <20231127173714.78D41C36D10@vcs2.savannah.gnu.org>
2023-11-29 19:14   ` master b8d4242e8bd 1/2: New user option 'shell-command-guess-functions' (bug#18132) Arash Esbati
2023-11-30  6:08     ` Eli Zaretskii [this message]
2023-11-30 17:22       ` Juri Linkov
2023-11-30 17:55         ` Eli Zaretskii
2023-11-30 18:12           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0k76aen.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=arash@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).