From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android Date: Thu, 07 Dec 2023 08:35:52 +0200 Message-ID: <83r0jy34fr.fsf@gnu.org> References: <170183012607.20763.1485814684546086922@vcs2.savannah.gnu.org> <20231206023526.8C80FC38EA3@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21026"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, luangruo@yahoo.com To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 07 07:36:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB7zw-0005Bi-Tj for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Dec 2023 07:36:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB7z8-00068o-15; Thu, 07 Dec 2023 01:35:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB7z6-00068f-RP for emacs-devel@gnu.org; Thu, 07 Dec 2023 01:35:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB7z6-0002F3-IK; Thu, 07 Dec 2023 01:35:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FetPMkLMjiUJZeh6A8xadtQtdzRoBLnVDEZvXsK14tU=; b=WpDMFxhHJ/6uL68bL+JP ybEtKocydGzSvoWq93LxEYkcDvkatMSaVtKW3mLU8OnlcMVGigw5V55fVTQvlWaeYJJ+L1GQMTcxH 11MFpFlaKACS9jIUAAZHlXT/711ZHJQUFTo4i+dPbD3RXRzfM9fhp8rhtWhHKfP30Oo3ehnR7Uz7B yGFbIUUVHfYVpzPMao3lpcaxbDMrZz8z4Oc6HIdo8/40YfTMDZQUY4bR5PtNLyiwrVzsevP0XqUUI +Qbb1XMcSuS8hSBqNETyeDi3uY7mqSQrAoapS00hTFv+hWsXJxUyH7510NWBZzVQCFpsulyjg+Rvg c5uRcX9IgZjZdw==; In-Reply-To: (message from Arash Esbati on Wed, 06 Dec 2023 23:12:21 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313581 Archived-At: > From: Arash Esbati > Cc: Po Lu > Date: Wed, 06 Dec 2023 23:12:21 +0100 > > Po Lu via Mailing list for Emacs changes writes: > > > branch: master > > commit d8a00879309a3bf62f6ffcae103aa3bdba776ee9 > > Author: Po Lu > > Commit: Po Lu > > > > Cease preloading touch-screen.el outside X and Android > > > > * lisp/calc/calc.el (touch-screen-display-keyboard): > > > > * lisp/minibuffer.el (clear-minibuffer-message): > > > > * lisp/term.el (touch-screen-display-keyboard): Declare > > touch-screen-display-keyboard before binding or setting it. > > > > * lisp/loadup.el: Don't autoload touch-screen.el outside X and > > Android. > > > > * lisp/touch-screen.el: Autoload functions called from commands > > responding to touch screen events. > > I think this change produces these warnings: > > In end of data: > button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not > known to be defined. > > In clear-minibuffer-message: > minibuffer.el:979:23: Warning: reference to free variable > ‘touch-screen-current-tool’ > > In tab-bar-touchscreen-begin: > tab-bar.el:440:55: Warning: reference to free variable > ‘touch-screen-delay’ > > In end of data: > dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known > to be defined. > > In tab-line-track-tap: > tab-line.el:978:50: Warning: reference to free variable > ‘touch-screen-delay’ > > This is with Emacs from master (d8a0087930) on macOS, built with: > > git clean -fdx > ./autogen > ./configure ... > make The two functions are autoloaded, so I'm guessing that the warnings go away once loaddefs.el is generated. The variables indeed need a defvar, I think.