From: Eli Zaretskii <eliz@gnu.org>
To: Arash Esbati <arash@gnu.org>
Cc: emacs-devel@gnu.org, luangruo@yahoo.com
Subject: Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android
Date: Thu, 07 Dec 2023 08:35:52 +0200 [thread overview]
Message-ID: <83r0jy34fr.fsf@gnu.org> (raw)
In-Reply-To: <m2il5b6kvu.fsf@macmutant.fritz.box> (message from Arash Esbati on Wed, 06 Dec 2023 23:12:21 +0100)
> From: Arash Esbati <arash@gnu.org>
> Cc: Po Lu <luangruo@yahoo.com>
> Date: Wed, 06 Dec 2023 23:12:21 +0100
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> > branch: master
> > commit d8a00879309a3bf62f6ffcae103aa3bdba776ee9
> > Author: Po Lu <luangruo@yahoo.com>
> > Commit: Po Lu <luangruo@yahoo.com>
> >
> > Cease preloading touch-screen.el outside X and Android
> >
> > * lisp/calc/calc.el (touch-screen-display-keyboard):
> >
> > * lisp/minibuffer.el (clear-minibuffer-message):
> >
> > * lisp/term.el (touch-screen-display-keyboard): Declare
> > touch-screen-display-keyboard before binding or setting it.
> >
> > * lisp/loadup.el: Don't autoload touch-screen.el outside X and
> > Android.
> >
> > * lisp/touch-screen.el: Autoload functions called from commands
> > responding to touch screen events.
>
> I think this change produces these warnings:
>
> In end of data:
> button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not
> known to be defined.
>
> In clear-minibuffer-message:
> minibuffer.el:979:23: Warning: reference to free variable
> ‘touch-screen-current-tool’
>
> In tab-bar-touchscreen-begin:
> tab-bar.el:440:55: Warning: reference to free variable
> ‘touch-screen-delay’
>
> In end of data:
> dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known
> to be defined.
>
> In tab-line-track-tap:
> tab-line.el:978:50: Warning: reference to free variable
> ‘touch-screen-delay’
>
> This is with Emacs from master (d8a0087930) on macOS, built with:
>
> git clean -fdx
> ./autogen
> ./configure ...
> make
The two functions are autoloaded, so I'm guessing that the warnings go
away once loaddefs.el is generated.
The variables indeed need a defvar, I think.
prev parent reply other threads:[~2023-12-07 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170183012607.20763.1485814684546086922@vcs2.savannah.gnu.org>
[not found] ` <20231206023526.8C80FC38EA3@vcs2.savannah.gnu.org>
2023-12-06 22:12 ` master d8a00879309: Cease preloading touch-screen.el outside X and Android Arash Esbati
2023-12-07 5:14 ` Po Lu
2023-12-07 7:31 ` Arash Esbati
2023-12-07 6:35 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0jy34fr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).