From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: gernotk@gmail.com, emacs-devel@gnu.org
Subject: Re: Treesit says grammar is unavailable when it
Date: Thu, 14 Dec 2023 10:27:30 +0200 [thread overview]
Message-ID: <83r0jpqjd9.fsf@gnu.org> (raw)
In-Reply-To: <D913C488-7326-43C2-84C4-093E5561C1F2@gmail.com> (message from Yuan Fu on Thu, 14 Dec 2023 00:14:01 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 14 Dec 2023 00:14:01 -0800
> Cc: gernotk@gmail.com,
> emacs-devel@gnu.org
>
> >> Thanks for sharing this! Eli, this sort of thing might be good reasons
> >> to also print the error message from ldopen, rather than simply saying
> >> not found?
> >
> > I don't mind, but IME relying too much on these error messages is not
> > always a good idea, since sometimes they are too generic and say
> > nothing except "this failed". But if it will help in some cases,
> > let's do it.
> >
> > However, I would like to see the patch, since we seem to be signaling
> > an error already, and the error includes the error message from
> > dynlib_open? So what am I missing?
>
> We were showing error messages from dlopen, and then removed them for brevity, see e8df6c311fcf59bf23d31b9db2bb8fec9d78fbe7
If these messages are useful, we can revert that commit.
> Maybe we can fold the extra error messages by default?
I'm not sure I understand the details, but the idea is certainly okay.
next prev parent reply other threads:[~2023-12-14 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:43 Treesit says grammar is unavailable when it Gernot Kieseritzky
2023-12-13 3:33 ` Yuan Fu
2023-12-13 12:00 ` Eli Zaretskii
2023-12-14 8:14 ` Yuan Fu
2023-12-14 8:27 ` Eli Zaretskii [this message]
2023-12-15 2:43 ` Madhu
2023-12-15 9:00 ` Eli Zaretskii
2023-12-17 6:31 ` Yuan Fu
2023-12-17 8:32 ` Eli Zaretskii
2023-12-27 6:41 ` Yuan Fu
-- strict thread matches above, loose matches on Subject: below --
2023-03-10 9:24 mprodrigues
2023-03-10 12:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0jpqjd9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gernotk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).