From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Redundant if clause in xdisp.c?
Date: Sun, 30 Aug 2009 21:06:31 +0300 [thread overview]
Message-ID: <83prad9nx4.fsf@gnu.org> (raw)
In-Reply-To: <jwvzl9i9v2o.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 29 Aug 2009 17:21:42 -0400
> Cc: emacs-devel@gnu.org
>
> >> These optimizations seem to be pointless nowadays: even when running
> >> Emacs-23 on my cell-phone (FreeRunner) displaying on my desktop, they
> >> don't make any noticeable difference.
>
> > How did you turn them off to measure their influence,
>
> I removed the corresponding code.
I think it's enough to set direction-reversed non-nil.
> > and with what kind of stuff in your buffer(s)?
>
> I tried it in *scratch* and in a Python-mode buffer (visiting
> /usr/bin/zhone), doing random movement and typing (especially using the
> auto-repeat to see when the redisplay keeps up and when it doesn't).
GUI session or tty? The price of disabling these optimizations might
be more visible on a tty via a relatively slow link. I don't think we
should remove them before we try at least that.
> Sure, I just wanted to make sure you don't waste time in these parts of
> the code.
The first rule of optimization: don't do it. The second rule of
optimization: don't do it yet. I'm somewhere before the first and the
second one: I need to get the code work right before I make it faster
(if needed).
prev parent reply other threads:[~2009-08-30 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 12:46 Redundant if clause in xdisp.c? Eli Zaretskii
2009-08-29 14:16 ` Chong Yidong
2009-08-29 15:50 ` Stefan Monnier
2009-08-29 17:40 ` Eli Zaretskii
2009-08-29 21:21 ` Stefan Monnier
2009-08-30 18:06 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83prad9nx4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).