From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: jasonr@gnu.org, 5703@debbugs.gnu.org, emacs-devel@gnu.org
Subject: Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top'
Date: Tue, 30 Mar 2010 16:15:37 +0300 [thread overview]
Message-ID: <83pr2mympy.fsf@gnu.org> (raw)
In-Reply-To: <87pr38rnan.fsf@stupidchicken.com>
> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Sat, 13 Mar 2010 15:15:12 -0500
> Cc: 5703@debbugs.gnu.org
>
> "Drew Adams" <drew.adams@oracle.com> wrote:
>
> > M-: (x-show-tip "aaaaaaaa" (selected-frame) '((left . 30) (top . 40)) 10 0 0)
> >
> > Instead of displaying the tooltip frame at the absolute
> > location specified by `left' and `top', it always displays it at the mouse
> > position plus the DX and DY (0 and 0 here).
>
> This is reported to be a regression against Emacs 22. Unfortunately,
> it's Windows-only, and I can't reproduce it. Could someone with access
> to a Windows box give it a shot?
I think the small patch below fixes this. But since this is about
pretest, I would like second opinion on that from anyone who is
familiar with this stuff (not only on MS-Windows). In particular, I'd
like to hear from Jason.
Please also try the patched version in as many different use-cases as
you can, to make sure it doesn't break anything.
Here's what I found to be the reason of the bug:
compute_tip_xy relies on the tip frame's parameters (passed to it
through the `parms' argument) for figuring out where to display the
tooltip. But by the time compute_tip_xy is called, the `top' and
`left' parameters were already removed from `parms'. That's because
x_create_tip_frame, called a few lines before that, calls
x_figure_window_size, which sets up f->top_pos and f->left_pos from
`top' and `left', and as a side effect removes them from the frame's
parameters alist.
I see almost identical code in xfns.c versions of these functions, so
I'd be interested to hear how come the X version does not suffer from
the same problem. That's because the patch below, although it does
the job, feels a bit kludgey, and I wonder if there a cleaner way.
=== modified file 'src/w32fns.c'
--- src/w32fns.c 2010-01-13 08:35:10 +0000
+++ src/w32fns.c 2010-03-30 12:57:13 +0000
@@ -5927,6 +5927,10 @@ Text larger than the specified size is c
/* Move the tooltip window where the mouse pointer is. Resize and
show it. */
compute_tip_xy (f, parms, dx, dy, width, height, &root_x, &root_y);
+ if (f->top_pos)
+ root_y = f->top_pos;
+ if (f->left_pos)
+ root_x = f->left_pos;
{
/* Adjust Window size to take border into account. */
next prev parent reply other threads:[~2010-03-30 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DF5796ECD96A4DD2807094BE7934B041@us.oracle.com>
2010-03-13 20:15 ` 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' Chong Yidong
2010-03-13 22:03 ` Christoph
2010-03-14 4:49 ` Drew Adams
2010-03-30 13:18 ` Eli Zaretskii
2010-03-30 13:15 ` Eli Zaretskii [this message]
2010-03-30 14:41 ` bug#5703: " Jason Rumney
2010-03-30 16:23 ` Eli Zaretskii
2010-03-30 23:33 ` YAMAMOTO Mitsuharu
2010-03-31 9:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pr2mympy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=5703@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).