From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Sun, 25 Jul 2010 23:44:46 +0300 Message-ID: <83pqybb8ap.fsf@gnu.org> References: <86iq4379w0.fsf@red.stonehenge.com> <86eier7942.fsf@red.stonehenge.com> <86aapf78af.fsf@red.stonehenge.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1280090757 2807 80.91.229.12 (25 Jul 2010 20:45:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 20:45:57 +0000 (UTC) Cc: lekktu@gmail.com, merlyn@stonehenge.com, emacs-devel@gnu.org To: Chad Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 22:45:53 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od84j-0001eZ-0T for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 22:45:52 +0200 Original-Received: from localhost ([127.0.0.1]:38659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od84W-0000jC-KA for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 16:45:20 -0400 Original-Received: from [140.186.70.92] (port=34303 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od84K-0000cK-Op for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:45:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Od844-0006pK-TX for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:44:53 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:42282) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od844-0006p7-LM for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:44:52 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L6400F00ROWQN00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sun, 25 Jul 2010 23:44:50 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.61.30]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L6400E2FSALMS60@a-mtaout23.012.net.il>; Sun, 25 Jul 2010 23:44:46 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127795 Archived-At: > From: Chad Brown > Date: Sun, 25 Jul 2010 13:12:26 -0700 > Cc: emacs-devel@gnu.org, "Randal L. Schwartz" >=20 > The resulting build gives warnings: >=20 > dired.c: In function =91Ffile_attributes=92: > dired.c:1016: warning: comparison is always false due to limited ra= nge of data type > dired.c:1016: warning: comparison is always false due to limited ra= nge of data type > dired.c:1020: warning: comparison is always false due to limited ra= nge of data type > dired.c:1020: warning: comparison is always false due to limited ra= nge of data type > dired.c:1068: warning: comparison is always false due to limited ra= nge of data type > dired.c:1068: warning: comparison is always false due to limited ra= nge of data type This is normal, don't worry about it. > It seems that Darwin's dirent.h prototype is: >=20 > DIR *opendir(const char *) >=20 > which conflicts with dired.c's unconditional (ifndef MSDOS) declara= tion: >=20 > extern DIR *opendir(char *) Darwin should pick up its dirent.h instead of these explicit prototypes, which are for systems that don't have dirent.h.