From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Changes in revision 106420 reverted Date: Sat, 19 Nov 2011 10:46:38 +0200 Message-ID: <83pqgobitt.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1321692521 9018 80.91.229.12 (19 Nov 2011 08:48:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Nov 2011 08:48:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 19 09:48:37 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRgbB-0003ig-ON for ged-emacs-devel@m.gmane.org; Sat, 19 Nov 2011 09:48:33 +0100 Original-Received: from localhost ([::1]:55509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRgbA-0004FZ-Tm for ged-emacs-devel@m.gmane.org; Sat, 19 Nov 2011 03:48:32 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:54341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRgb8-0004FJ-Go for emacs-devel@gnu.org; Sat, 19 Nov 2011 03:48:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRgb7-0002ui-GD for emacs-devel@gnu.org; Sat, 19 Nov 2011 03:48:30 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:59492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRgb7-0002uc-8a for emacs-devel@gnu.org; Sat, 19 Nov 2011 03:48:29 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LUW00600GCPQA00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 19 Nov 2011 10:48:27 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.237.133]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUW00652GGR6JA0@a-mtaout20.012.net.il>; Sat, 19 Nov 2011 10:48:27 +0200 (IST) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146095 Archived-At: Sorry about that. I reverted these because the functions I made external are explicitly intended to be that. I don't want to need to convert them back from static when they are called from outside the module that defines them. Hash codes of glyph rows are manipulated both in xdisp.c and in dispnew.c, so the natural thing for these functions is to be external, not static. Besides, code like this: #if !XASSERTS static #endif unsigned row_hash (struct glyph_row *row) { is butt-ugly, IMNSHO. There's a limit to which we should go to pacify overly-pedantic compiler switches, and this is way out.