From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Changes in revision 106420 reverted
Date: Sat, 19 Nov 2011 10:46:38 +0200 [thread overview]
Message-ID: <83pqgobitt.fsf@gnu.org> (raw)
Sorry about that.
I reverted these because the functions I made external are explicitly
intended to be that. I don't want to need to convert them back from
static when they are called from outside the module that defines them.
Hash codes of glyph rows are manipulated both in xdisp.c and in
dispnew.c, so the natural thing for these functions is to be external,
not static.
Besides, code like this:
#if !XASSERTS
static
#endif
unsigned
row_hash (struct glyph_row *row)
{
is butt-ugly, IMNSHO. There's a limit to which we should go to pacify
overly-pedantic compiler switches, and this is way out.
next reply other threads:[~2011-11-19 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 8:46 Eli Zaretskii [this message]
2011-11-19 13:55 ` Changes in revision 106420 reverted Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pqgobitt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).