From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115596: Minor fixes for recent openp changes. Date: Thu, 19 Dec 2013 19:00:34 +0200 Message-ID: <83pposbwst.fsf@gnu.org> References: <52B21CBB.4050506@poczta.onet.pl> <52B2258B.6040201@cs.ucla.edu> <52B29DC0.7030004@poczta.onet.pl> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1387472432 20173 80.91.229.3 (19 Dec 2013 17:00:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Dec 2013 17:00:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jarek Czekalski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 19 18:00:38 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vtgxg-0004hR-KG for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2013 18:00:36 +0100 Original-Received: from localhost ([::1]:45325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtgxf-0005xk-Pl for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2013 12:00:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtgxT-0005lZ-Kg for emacs-devel@gnu.org; Thu, 19 Dec 2013 12:00:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtgxN-0003KA-VE for emacs-devel@gnu.org; Thu, 19 Dec 2013 12:00:23 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:46764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtgxN-0003JU-NT for emacs-devel@gnu.org; Thu, 19 Dec 2013 12:00:17 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MY200K00CICBV00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 19 Dec 2013 19:00:16 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MY200JU1CKFI9S0@a-mtaout21.012.net.il>; Thu, 19 Dec 2013 19:00:16 +0200 (IST) In-reply-to: <52B29DC0.7030004@poczta.onet.pl> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166614 Archived-At: > Date: Thu, 19 Dec 2013 08:18:24 +0100 > From: Jarek Czekalski > > src/lread.c: > /* The last-modified time of the newest matching file found. > Initialize it to something less than all valid timestamps. */ > struct timespec save_mtime = make_timespec (TYPE_MINIMUM (time_t), -1); > > But -1 makes this struct invalid. How can we be sure that comparing an > invalid timestamp to a valid timestamp gives us the expected result? Look at timespec_cmp, and you will know.