From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#21602: 25.0.50; coding system seg fault Date: Sat, 03 Oct 2015 19:11:56 +0300 Message-ID: <83pp0w2apf.fsf@gnu.org> References: <83vbap7nv6.fsf@gnu.org> <83fv1s448p.fsf@gnu.org> <878u7kb34s.fsf@igel.home> <83bncg41c4.fsf@gnu.org> <87zj009mj0.fsf@igel.home> <834mi83yz0.fsf@gnu.org> <87mvw09kvp.fsf@igel.home> <831tdc3xg5.fsf@gnu.org> <83wpv42fw2.fsf@gnu.org> <87fv1s9euj.fsf@igel.home> <83twq82cta.fsf@gnu.org> <874mi89boe.fsf@igel.home> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443888745 25996 80.91.229.3 (3 Oct 2015 16:12:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Oct 2015 16:12:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 03 18:12:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZiPQ0-0001DK-7b for ged-emacs-devel@m.gmane.org; Sat, 03 Oct 2015 18:12:16 +0200 Original-Received: from localhost ([::1]:39134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiPPu-0001dR-PV for ged-emacs-devel@m.gmane.org; Sat, 03 Oct 2015 12:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiPPr-0001dK-TT for emacs-devel@gnu.org; Sat, 03 Oct 2015 12:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZiPPn-000409-So for emacs-devel@gnu.org; Sat, 03 Oct 2015 12:12:07 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:44385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiPPn-000400-L4 for emacs-devel@gnu.org; Sat, 03 Oct 2015 12:12:03 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NVN00700IMLP700@mtaout24.012.net.il> for emacs-devel@gnu.org; Sat, 03 Oct 2015 19:04:58 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVN00LYRJCA9570@mtaout24.012.net.il>; Sat, 03 Oct 2015 19:04:58 +0300 (IDT) In-reply-to: <874mi89boe.fsf@igel.home> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190795 Archived-At: > From: Andreas Schwab > Cc: emacs-devel@gnu.org > Date: Sat, 03 Oct 2015 18:09:05 +0200 > > It is wrong to error out if select-safe-coding-system-function returns > nil. Agreed (I didn't think CHECK_CODING_SYSTEM will barf in that case). So the result should only checked if it's non-nil.