Re: bug#21602: 25.0.50; coding system seg fault

Re: bug#21602: 25.0.50; coding system seg fault

[Eli Zaretskii]

Please revert b235cea, or I will.

This kind of conduct, where the change you think should be made was
explicitly objected to, but you still make it on your own, is not to
be tolerated here.  It's not your private project.  If you are
unconvinced, please feel free to try to convince the disagreeing
parties, instead of abusing your write access.

TIA

Re: bug#21602: 25.0.50; coding system seg fault

[Andreas Schwab]

It is pretty stupid to check before the call if the callee does it
immediately again.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: bug#21602: 25.0.50; coding system seg fault

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 03 Oct 2015 17:00:36 +0200
> 
> It is pretty stupid to check before the call if the callee does it
> immediately again.

I already explained why I don't consider this stupid.  I'm open to
hear additional arguments to countermand what I said ("stupid" doesn't
cut it), but only after you revert the parts of your commit that
changed what you consider "stupid" (I have nothing against the first 2
hunks).  I might even change my mind if you give convincing arguments.

There should be some minimal level of civilized behavior here.

Re: bug#21602: 25.0.50; coding system seg fault

[Andreas Schwab]

It is wrong to error out if select-safe-coding-system-function returns
nil.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: bug#21602: 25.0.50; coding system seg fault

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 03 Oct 2015 18:09:05 +0200
> 
> It is wrong to error out if select-safe-coding-system-function returns
> nil.

Agreed (I didn't think CHECK_CODING_SYSTEM will barf in that case).
So the result should only checked if it's non-nil.

Re: bug#21602: 25.0.50; coding system seg fault

[Zack Piper]

On Sat, Oct 03, 2015 at 05:19:57PM +0300, Eli Zaretskii wrote:
> Please revert b235cea, or I will.
> 
> This kind of conduct, where the change you think should be made was
> explicitly objected to, but you still make it on your own, is not to
> be tolerated here.  It's not your private project.  If you are
> unconvinced, please feel free to try to convince the disagreeing
> parties, instead of abusing your write access.
> 
> TIA
> 

That commit caused:


Debugger entered--Lisp error: (wrong-type-argument coding-system-p
nil)
call-process("editorconfig" nil "ecbuffer" nil
"/home/zack/.emacs.d/config.org")
edconf-get-properties()
edconf-find-file-hook()
run-hooks(find-file-hook)
after-find-file(nil t)
find-file-noselect-1(#<buffer config.org>
"~/.emacs.d/config.org" nil nil
"~/.homesick/repos/dotfiles/home/.emacs.d/config.org"
(559853$
find-file-noselect("~/.emacs.d/config.org" nil nil nil)
find-file("~/.emacs.d/config.org")
org-babel-tangle-file("~/.emacs.d/config.org"
"~/.emacs.d/config.el" "emacs-lisp")
org-babel-load-file("~/.emacs.d/config.org")
eval-buffer(#<buffer  *load*> nil
"/home/zack/.emacs.d/init.el" nil t)  ; Reading
at buffer position 2342
load-with-code-conversion("/home/zack/.emacs.d/init.el"
"/home/zack/.emacs.d/init.el" t t)
load("/home/zack/.emacs.d/init" t t)
))

For me at least.

-- 
Zack Piper <zack@apertron.net> http://apertron.net

Re: bug#21602: 25.0.50; coding system seg fault

[Andreas Schwab]

Zack Piper <zack@apertron.net> writes:

> That commit caused:
>
>
> Debugger entered--Lisp error: (wrong-type-argument coding-system-p
> nil)

Sorry, I've removed that check again.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."