From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Sun, 20 Dec 2015 17:48:48 +0200 Message-ID: <83poy1t927.fsf@gnu.org> References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> <83io4nuc68.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450626565 22320 80.91.229.3 (20 Dec 2015 15:49:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Dec 2015 15:49:25 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 20 16:49:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aAgEY-0003Ne-Nz for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 16:49:18 +0100 Original-Received: from localhost ([::1]:41099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAgEX-0005oB-PH for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 10:49:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAgDw-0005C8-Go for emacs-devel@gnu.org; Sun, 20 Dec 2015 10:48:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAgDe-0005D7-1U for emacs-devel@gnu.org; Sun, 20 Dec 2015 10:48:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAgDd-0005Cw-Pw; Sun, 20 Dec 2015 10:48:21 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4400 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aAgDb-0004WA-Jp; Sun, 20 Dec 2015 10:48:20 -0500 In-reply-to: (message from Philipp Stephani on Sat, 19 Dec 2015 21:03:32 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196554 Archived-At: > From: Philipp Stephani > Date: Sat, 19 Dec 2015 21:03:32 +0000 > Cc: dancol@dancol.org, tzz@lifelogs.com, aurelien.aptel+emacs@gmail.com, > emacs-devel@gnu.org > > Here's another patch that replaces some of the custom error handling with > signals. The signals will be immediately caught by the prologue, but some > complexity and duplication is removed. Thanks. Did you run the mod-test test suite, and did you make sure that signaling an error from a module still reports the same information and backtrace as before the change?