From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [master b3cf281] Unbreak the MinGW build Date: Sat, 17 Dec 2016 09:51:15 +0200 Message-ID: <83pokr6ljg.fsf@gnu.org> References: <83eg1887q4.fsf@gnu.org> <10588713.4sEyyCWImg@linuix.haible.de> <83y3zf7f6k.fsf@gnu.org> <3331192.fdZnPqnNIH@linuix.haible.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481961135 29745 195.159.176.226 (17 Dec 2016 07:52:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 07:52:15 +0000 (UTC) Cc: bug-gnulib@gnu.org, emacs-devel@gnu.org To: Bruno Haible Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Sat Dec 17 08:52:11 2016 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cI9mr-0006dU-W5 for gnu-bug-gnulib@m.gmane.org; Sat, 17 Dec 2016 08:52:10 +0100 Original-Received: from localhost ([::1]:35616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cI9mu-0007ay-Ut for gnu-bug-gnulib@m.gmane.org; Sat, 17 Dec 2016 02:52:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cI9mg-0007SK-Ua for bug-gnulib@gnu.org; Sat, 17 Dec 2016 02:52:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cI9mc-0000U7-A8 for bug-gnulib@gnu.org; Sat, 17 Dec 2016 02:51:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cI9mc-0000U3-6g; Sat, 17 Dec 2016 02:51:54 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3358 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cI9mb-00067C-Dw; Sat, 17 Dec 2016 02:51:53 -0500 In-reply-to: <3331192.fdZnPqnNIH@linuix.haible.de> (message from Bruno Haible on Sat, 17 Dec 2016 00:17:31 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:36548 gmane.emacs.devel:210574 Archived-At: > From: Bruno Haible > Cc: bug-gnulib@gnu.org > Date: Sat, 17 Dec 2016 00:17:31 +0100 > > Since, as you say, the crash occurs during dumping, this is what I would > turn to now. Do you have a systematic approach for debugging crashes during > dump? If dump is based on malloc, does it help to set MALLOC_PERTURB_? > Can you use tools such as valgrind to debug it? Why would I need them? The dumping code on Windows is just C code that reads and writes a binary file, so GDB is good enough, it shows exactly what causes the crash. Except that what it told me made very little sense, so I tried the "blame the last change" approach. Which worked, even though examining the source-level changes clearly indicates that the new fpending.c does the same as the old one did, as long as you compare the executable C code in the two versions. > Actually gnulib has a way to keep in your project changes relative to gnulib > that should not be pushed upstream: It's gnulib-tool's --local-dir option. > You would have had to create a small lib/stdio-impl.h.diff file that gets > applied on the fly each time you invoke gnulib-tool for emacs. I didn't ask to propagate the change back into Gnulib, that was Paul's decision. I understand his motivation, but I'm okay with anything you decide about Gnulib. I will try to look into this some more today, and see if I can unlock the mystery. It bothers me, too. Thanks.