From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] Support 24-bit terminal colors. Date: Mon, 13 Feb 2017 07:41:07 +0200 Message-ID: <83poim1wcs.fsf@gnu.org> References: <1486893930-6709-1-git-send-email-rami.ylimaki@vincit.fi> <83tw7z16hv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1486964461 30737 195.159.176.226 (13 Feb 2017 05:41:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Feb 2017 05:41:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Rami =?utf-8?Q?Ylim=C3=A4ki?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 13 06:40:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd9Ng-0007h4-85 for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 06:40:56 +0100 Original-Received: from localhost ([::1]:54652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd9Nl-0005x9-RR for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 00:41:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd9Nf-0005x3-Ly for emacs-devel@gnu.org; Mon, 13 Feb 2017 00:40:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd9Nc-0005YF-JA for emacs-devel@gnu.org; Mon, 13 Feb 2017 00:40:55 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd9Nc-0005YB-GD; Mon, 13 Feb 2017 00:40:52 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4895 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cd9Nb-000536-73; Mon, 13 Feb 2017 00:40:51 -0500 In-reply-to: (message from Rami =?utf-8?Q?Ylim=C3=A4ki?= on Mon, 13 Feb 2017 00:53:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212321 Archived-At: > From: Rami Ylimäki > Date: Mon, 13 Feb 2017 00:53:47 +0200 > Cc: emacs-devel@gnu.org > > . Please prepare a NEWS entry for this feature. > . It seems like you dropped the code to support the --color= > command-line argument, which was part of your original submission? > All the other color TTY modes support --color=NUM, so I think we > should also support --color=16777216, and perhaps also --color-24bit. > > I'll write the NEWS entry but I'm afraid that fixing the --color=NUM option would require too much effort right > now. > > The manual is too optimistic when it states that "Emacs might be able to turn on a color mode for 8, 16, 88, or > 256 as the value of NUM". In reality, only -1, 0 and 8 are supported. The 16, 88, and 256 color modes can only > be enabled based on current terminal capabilities and this is now true for the 16M color mode as well. > > The problems of handling --color=NUM can be seen when colors are downgraded, because color and face > pixel values aren't updated. For example, "M-x list-faces-display" produces different results with "TERM=xterm > emacs -Q -nw --color=8" and "TERM=xterm-256color emacs -Q -nw --color=8". This is why I'd like to treat the > --color option as a separate issue. Fair enough, thanks.