From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg Date: Tue, 02 May 2017 09:29:35 +0300 Message-ID: <83pofrixf4.fsf@gnu.org> References: <20170427222412.28742.14016@vcs0.savannah.gnu.org> <20170427222413.8FBA722040@vcs0.savannah.gnu.org> <07e00044-4ce1-bba8-2fe5-4e7eb7fb27a6@cornell.edu> <269c5353-d07b-5cf0-4009-3d817351c470@cs.ucla.edu> <83h915ja41.fsf@gnu.org> <175dace6-c544-a0ac-2e96-b378b3c6f49d@cs.ucla.edu> <83shkoid2k.fsf@gnu.org> <8836de3f-eeda-ec8d-fff1-ef68ec808389@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1493706649 17833 195.159.176.226 (2 May 2017 06:30:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 May 2017 06:30:49 +0000 (UTC) Cc: kbrown@cornell.edu, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 02 08:30:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5RKb-0004UX-UM for ged-emacs-devel@m.gmane.org; Tue, 02 May 2017 08:30:42 +0200 Original-Received: from localhost ([::1]:56959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5RKh-000686-Ma for ged-emacs-devel@m.gmane.org; Tue, 02 May 2017 02:30:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5RK0-0005zZ-If for emacs-devel@gnu.org; Tue, 02 May 2017 02:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5RJx-0005lk-FE for emacs-devel@gnu.org; Tue, 02 May 2017 02:30:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5RJx-0005lf-CQ; Tue, 02 May 2017 02:30:01 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1419 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d5RJw-0002Qq-4g; Tue, 02 May 2017 02:30:00 -0400 In-reply-to: <8836de3f-eeda-ec8d-fff1-ef68ec808389@cs.ucla.edu> (message from Paul Eggert on Mon, 1 May 2017 16:05:21 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214507 Archived-At: > Cc: kbrown@cornell.edu, emacs-devel@gnu.org > From: Paul Eggert > Date: Mon, 1 May 2017 16:05:21 -0700 > > On 05/01/2017 12:36 PM, Eli Zaretskii wrote: > > Thanks. This version still has problems in the MinGW build: > > Oh my, I wasn't aware that MinGW timezones were so limited. More accurately, the support for the timezone specs via the TZ environment variable is very limited. The native Windows way of specifying timezones is as rich as that on Posix systems, but it uses programmatic APIs, not environment variables or databases stored on files. > I installed the attached to try to fix the test accordingly. Thanks, all the tests now pass. However, the utimens.c file you've brought from Gnulib has 2 problems: . it defines WIN32_LEAN_AND_MEAN unconditionally, which conflicts with our own definition in nt/inc/ms-w32.h, which is processed earlier; . it includes msvc-nothrow.h, which is absent in the repository, it should have been imported from Gnulib together with utimens.c I fixed the first of these temporarily, in a way that at least GCC lets utimens.c compile, but I think in general utimens.c should do #ifndef WIN32_LEAN_AND_MEAN # define WIN32_LEAN_AND_MEAN #endif to avoid possible clashes with definitions elsewhere in the sources.