From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Tue, 01 Aug 2017 22:04:26 +0300 Message-ID: <83pocfyurp.fsf@gnu.org> References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501614344 18073 195.159.176.226 (1 Aug 2017 19:05:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 19:05:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 01 21:05:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dccU5-0004FN-Um for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 21:05:38 +0200 Original-Received: from localhost ([::1]:44111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dccU8-00051h-HT for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 15:05:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dccTR-00051M-5i for emacs-devel@gnu.org; Tue, 01 Aug 2017 15:04:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dccTJ-0004Xa-FK for emacs-devel@gnu.org; Tue, 01 Aug 2017 15:04:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dccTJ-0004XM-Co; Tue, 01 Aug 2017 15:04:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1035 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dccTG-0006nD-QN; Tue, 01 Aug 2017 15:04:49 -0400 In-reply-to: <87d18fw79z.fsf@calancha-pc> (message from Tino Calancha on Wed, 02 Aug 2017 02:02:32 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217220 Archived-At: > From: Tino Calancha > Cc: emacs-devel@gnu.org, tino.calancha@gmail.com > Date: Wed, 02 Aug 2017 02:02:32 +0900 > > > dired-tests.log: > > Test dired-test-bug25609 condition: > > (ert-test-failed > > ((should > > (file-exists-p target)) > > :form > > (file-exists-p "c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/bar6828Ler/foo6828WPJ") > > :value nil)) > Could you check the following? I could, but I don't understand the purpose. This form is almost identical to what's in dired-tests.el, and I already established that the failure is indeed because 'target' doesn't exist at that moment. I just didn't dig deep enough to understand why, because I didn't really understand what the code wants to do, e.g. why it calls dired-do-copy twice, and more importantly why 'target' is supposed to exist after all that. What I see here is that at the point where file-exists-p is called, there are two directories: /bla/blah/foNNNNNN and /bla/bla/barKKKKKK, but not /bla/bla/fooNNNNN/barKKKKKK, as I think the code expects. maybe if you could explain the idea behind the code I could think of a reason why it doesn't work here. > > Test dired-test-bug27631 backtrace: > > signal(error ("em-ls is not a currently loaded feature")) > > error("%s is not a currently loaded feature" "em-ls") > > unload-feature(em-ls force) > > (unwind-protect (progn (make-directory dir1) (make-directory dir2) ( > > (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1 (expand-file-nam > > (closure (t) nil (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1 > > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > > ert-run-test(#s(ert-test :name dired-test-bug27631 :documentation "T > > ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test > > ert-run-tests(t #f(compiled-function (event-type &rest event-args) # > > ert-run-tests-batch(nil) > > ert-run-tests-batch-and-exit(nil) > > eval((ert-run-tests-batch-and-exit nil)) > > command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/dired-tests.el" "--e > > command-line() > > normal-top-level() > > Test dired-test-bug27631 condition: > > (error "em-ls is not a currently loaded feature") > I don't get this error, but the idea of require > those libs and unload them looks ugly. I think we need to understand why the problem happens before we decide how to proceed. > > ediff-ptch-tests.log: > > > > Running 2 tests (2017-08-01 18:21:40+0300) > > passed 1/2 ediff-ptch-test-bug25010 > > Test ediff-ptch-test-bug26084 backtrace: > > Test ediff-ptch-test-bug26084 condition: > > (wrong-type-argument stringp nil) > > FAILED 2/2 ediff-ptch-test-bug26084 > I think this test for Bug#26084 is more complicated than the > fix of the bug itself. It has also problems because the different > idiosyncrasy respect to "-b" option for different versions of "patch". > Delete it? I don't know. What does it try to test? > Skipped it unless in a GNU system? Only if there's no better way. The Patch invocation definitely needs the --binary switch on Windows, though. But the failure above is not about that, it's about something else, because directory-files returns an empty list. Something prevents Patch from creating backup files.