From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el
Date: Mon, 09 Oct 2017 19:18:14 +0300 [thread overview]
Message-ID: <83po9wqoqh.fsf@gnu.org> (raw)
In-Reply-To: <jwv1smcb9j0.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Mon, 09 Oct 2017 11:57:11 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Mon, 09 Oct 2017 11:57:11 -0400
>
> > - (set (make-local-variable (car local))
> > - (cdr local)))))
> > + ;; Cloning message-default-charset could cause an already
> > + ;; encoded text to be encoded again, yielding raw bytes
> > + ;; instead of characters in the message.
> > + (unless (string-match "message-default-charset"
> > + (symbol-name (car local)))
> > + (set (make-local-variable (car local))
> > + (cdr local))))))
>
> Could you add a comment explaining why we do
>
> (string-match "message-default-charset" (symbol-name (car local))
>
> rather than
>
> (eq 'message-default-charset (car local))
No reason except that this was in the patch proposed by Alex. Feel
free to change.
next prev parent reply other threads:[~2017-10-09 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171009134715.11038.14309@vcs0.savannah.gnu.org>
[not found] ` <20171009134716.77ADE201F1@vcs0.savannah.gnu.org>
2017-10-09 15:57 ` [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el Stefan Monnier
2017-10-09 16:18 ` Eli Zaretskii [this message]
2017-10-09 16:33 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83po9wqoqh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).