From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: fix for bug#29935 copyright-update inserts year at random places Date: Mon, 08 Jan 2018 21:05:25 +0200 Message-ID: <83po6k6uiy.fsf@gnu.org> References: <868tdh5fag.fsf@stephe-leake.org> <837et0ckou.fsf@gnu.org> <86shbm4ks9.fsf@stephe-leake.org> <86k1wy48ch.fsf@stephe-leake.org> <861sj54wox.fsf@stephe-leake.org> <5A524604.6070909@gmx.at> <5A533F7D.4090505@gmx.at> <86o9m4gug4.fsf@stephe-leake.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1515438240 2462 195.159.176.226 (8 Jan 2018 19:04:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Jan 2018 19:04:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 08 20:03:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYci2-000834-Ai for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 20:03:46 +0100 Original-Received: from localhost ([::1]:52211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYck1-0003dP-PV for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 14:05:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYcju-0003cE-U0 for emacs-devel@gnu.org; Mon, 08 Jan 2018 14:05:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYcjq-00058m-0G for emacs-devel@gnu.org; Mon, 08 Jan 2018 14:05:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYcjp-00058b-Nx; Mon, 08 Jan 2018 14:05:37 -0500 Original-Received: from [176.228.60.248] (port=3483 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYcjp-0001lb-2q; Mon, 08 Jan 2018 14:05:37 -0500 In-reply-to: <86o9m4gug4.fsf@stephe-leake.org> (message from Stephen Leake on Mon, 08 Jan 2018 10:56:59 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221720 Archived-At: > From: Stephen Leake > Date: Mon, 08 Jan 2018 10:56:59 -0600 > > This thread is nominally about patching emacs-26 to fix a bug. The patch > I've posted is a minimal fix; adding code or redesigning to handle frames > better is feature-creep, so it should be done on master. I think the bug happens because we use save-window-excursion, and switch buffers inside it. The cure should be not to do what hurts. Can this be done in this case? If not, why not? And why do we use save-window-excursion in the first place? that's not the usual way to display a buffer whose contents is referenced in an error message or a prompt. Thanks.