From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'
Date: Fri, 16 Feb 2018 19:22:20 +0200 [thread overview]
Message-ID: <83po54df3n.fsf@gnu.org> (raw)
In-Reply-To: <4finawzxei.fsf@fencepost.gnu.org> (message from Glenn Morris on Fri, 16 Feb 2018 11:56:05 -0500)
> From: Glenn Morris <rgm@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 16 Feb 2018 11:56:05 -0500
>
> > * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
> > work with Git for Windows.
> > - (string-match "git version \\([0-9.]+\\)$"
> > - version-string))
> > + ;; Git for Windows appends ".windows.N" to the
> > + ;; numerical version reported by Git.
> > + (string-match
> > + "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> > + version-string))
>
> Surely this breaks on all non-MS Windows platforms?
Given how much time it was "broken" on Windows without anyone
noticing, isn't it just fair that we leave it "broken" on non-Windows
platforms for approximately the same time?
next prev parent reply other threads:[~2018-02-16 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180216093116.572.67356@vcs0.savannah.gnu.org>
[not found] ` <20180216093117.66FB5206A2@vcs0.savannah.gnu.org>
2018-02-16 16:56 ` emacs-26 6ddb4bd: Fix 'vc-git--program-version' Glenn Morris
2018-02-16 17:22 ` Eli Zaretskii [this message]
2018-02-18 0:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83po54df3n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).