From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 13 Apr 2019 20:20:19 +0300 Message-ID: <83pnppkejw.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87h8b4tl6n.fsf@gmail.com> <83pnprkpw5.fsf@gnu.org> <87tvf3uhp2.fsf@gmail.com> <83imvjkmrf.fsf@gnu.org> <874l71vplj.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264039"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 13 19:21:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFML0-0016Sb-JY for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 19:21:10 +0200 Original-Received: from localhost ([127.0.0.1]:54097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFMKz-0001jy-I2 for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 13:21:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFMKP-0001ji-3I for emacs-devel@gnu.org; Sat, 13 Apr 2019 13:20:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFMKO-0004Pd-V3; Sat, 13 Apr 2019 13:20:33 -0400 Original-Received: from [176.228.60.248] (port=3073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFMKO-0007r0-7S; Sat, 13 Apr 2019 13:20:32 -0400 In-reply-to: <874l71vplj.fsf@gmail.com> (message from Alex Gramiak on Sat, 13 Apr 2019 10:26:16 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235405 Archived-At: > From: Alex Gramiak > Cc: emacs-devel@gnu.org > Date: Sat, 13 Apr 2019 10:26:16 -0600 > > > It's okay to add such a comment, although the _P part of the name, > > which stands for "Predicate", is supposed to say that already. > > Right, I was just mildly concerned since the comment by it mentions that > "it's defined to be the predicate for the window system being used", > which might not be good for code to rely on in the very long-term. > > I removed that part of the comment in the patch series I just posted, is > that an acceptable change? If the comment no longer fits the code, then the comment should be updated, sure.