From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Unbreak build when building without GMP support.
Date: Wed, 24 Apr 2019 22:06:13 +0300
Message-ID: <83pnpb1avu.fsf@gnu.org>
References: <CAArVCkT77BGUGP5o7BR-V2xwoQJqMdWmOaYgLh9NqsVErAp7nA@mail.gmail.com>
	<20190424175105.90319-1-phst@google.com> <83tven1c0y.fsf@gnu.org>
	<CAArVCkQ2pGrzGzgM=_NZHChvnbhebD+_QfhOS5BQ2HMyep3fgg@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="98903"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 24 21:18:48 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hJNPr-000Pca-FO
	for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 21:18:47 +0200
Original-Received: from localhost ([127.0.0.1]:46066 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hJNPq-00035p-4V
	for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 15:18:46 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:48525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hJNE1-0000zg-Oi
	for emacs-devel@gnu.org; Wed, 24 Apr 2019 15:06:34 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34622)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hJNE1-0000Zz-EY; Wed, 24 Apr 2019 15:06:33 -0400
Original-Received: from [176.228.60.248] (port=4085 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hJNDy-00034s-Ec; Wed, 24 Apr 2019 15:06:33 -0400
In-reply-to: <CAArVCkQ2pGrzGzgM=_NZHChvnbhebD+_QfhOS5BQ2HMyep3fgg@mail.gmail.com>
	(message from Philipp Stephani on Wed, 24 Apr 2019 20:49:34 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235876
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235876>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed, 24 Apr 2019 20:49:34 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>, Philipp Stephani <phst@google.com>
> 
> > Btw, why are we including emacs-module.h in lisp.h?  IME, this usually
> > causes trouble, so it is best to avoid that.
> 
> lisp.h needs types from emacs-module.h to define Lisp_Module_Function.

A single data type?  I'd rather move XMODULE_FUNCTION to
emacs-module.c, and the data type definition and all the other related
stuff to emacs-module.h.  It isn't worth the hassle.