From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: scratch/X_Typedefs 09c65d6 5/7: Introduce Emacs_GC struct and typedef Date: Wed, 15 May 2019 19:22:14 +0300 Message-ID: <83pnoj8z7t.fsf@gnu.org> References: <20190513175241.9359.28585@vcs0.savannah.gnu.org> <20190513175245.1B38320664@vcs0.savannah.gnu.org> <87sgthgjcj.fsf@gmail.com> <87o945ghk9.fsf@gmail.com> <87k1etggnw.fsf@gmail.com> <838sv8an50.fsf@gnu.org> <87bm04hl6u.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75702"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 15 18:22:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQwfx-000JPw-5N for ged-emacs-devel@m.gmane.org; Wed, 15 May 2019 18:22:41 +0200 Original-Received: from localhost ([127.0.0.1]:39495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQwfv-0005dw-W8 for ged-emacs-devel@m.gmane.org; Wed, 15 May 2019 12:22:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQwfk-0005cj-JX for emacs-devel@gnu.org; Wed, 15 May 2019 12:22:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQwfi-0006LW-Mu; Wed, 15 May 2019 12:22:27 -0400 Original-Received: from [176.228.60.248] (port=3891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQwfi-00076z-2C; Wed, 15 May 2019 12:22:26 -0400 In-reply-to: <87bm04hl6u.fsf@gmail.com> (message from Alex Gramiak on Tue, 14 May 2019 13:48:09 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236543 Archived-At: > From: Alex Gramiak > Cc: emacs-devel@gnu.org > Date: Tue, 14 May 2019 13:48:09 -0600 > > > CC dispnew.o > > In file included from dispnew.c:48:0: > > w32term.h:371:3: error: unknown type name 'Cursor' > > Cursor current_cursor; > > ^~~~~~ > > [...] > > Whoops, I forgot about that lonesome cursor. I pushed a fix for that. Thanks, it builds now. Regarding the patch, I have only one comment: > @@ -1289,7 +1317,7 @@ struct glyph_string > enum glyph_row_area area; > > /* Characters to be drawn, and number of characters. */ > - XChar2b *char2b; > + unsigned short *char2b; > int nchars; Why use 'unsigned short' and not 'unsigned int'? The latter is more efficient on modern architectures, and in structures you will likely have the compiler pad the following 16 bits anyway.