From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: [Emacs-diffs] master a59839d: file-truename now uses realpath for local files Date: Sat, 07 Sep 2019 10:27:05 +0300 Message-ID: <83pnkc5zxy.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130881"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 07 09:27:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6V8O-000XtT-2L for ged-emacs-devel@m.gmane.org; Sat, 07 Sep 2019 09:27:48 +0200 Original-Received: from localhost ([::1]:33628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6V8M-00038k-Ay for ged-emacs-devel@m.gmane.org; Sat, 07 Sep 2019 03:27:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46939) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6V7j-00038S-AU for emacs-devel@gnu.org; Sat, 07 Sep 2019 03:27:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i6V7i-00016P-Nd; Sat, 07 Sep 2019 03:27:06 -0400 Original-Received: from [176.228.60.248] (port=4449 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i6V7h-0003HF-OW; Sat, 07 Sep 2019 03:27:06 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239913 Archived-At: Paul, I had to revert this commit, as it had multiple issues: . It breaks the MS-Windows build, because there's no realpath (and we cannot use the Gnulib replacement, due to non-ASCII file names Gnulib doesn't support well on Windows). . Even when I modified file--truename to always signal an error on MS-Windows, Emacs wouldn't build, probably because the corresponding change in files.el has another mistake. Did you test the build when realpath signals an error? . I don't think it's a good idea to favor GNU/Linux systems by punishing the rest. We should have a better way than signaling an error on platforms where realpath doesn't work well enough. And in any case, using Gnulib's realpath will not make file-truename faster on those other systems. . The code of file--truename incorrectly looked for the trailing slash ion the encoded file name, something you can only do reliably if the file-name encoding is UTF-8, because other encodings don't guarantee a single slash is never part of a multibyte sequence. . Last, but not least: there was no documentation of the new primitive. For all of these reasons, I think we need to talk about the issue before implementing it, and the implementation, if we will have one, should resolve all of the problems mentioned above.