From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Wed, 09 Oct 2019 15:32:18 +0300 Message-ID: <83pnj6umjx.fsf@gnu.org> References: <20191008085604.tjtxm6ndyuluocbs@Ergus> <83lftvy4s6.fsf@gnu.org> <20191008160038.6xvnytnoruzphzd6@Ergus> <83zhibw6qn.fsf@gnu.org> <20191008164048.bnad4wdkcbatqepp@Ergus> <83v9szw4o4.fsf@gnu.org> <20191008234350.ahxt4zcylxqludoc@Ergus> <837e5ewc0a.fsf@gnu.org> <20191009103936.qjdwuidqnowswojw@Ergus> <83wodeup6a.fsf@gnu.org> <20191009120534.ud6st2xvrv3rv6iy@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="186849"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , emacs-devel@gnu.org, juri@linkov.net To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 19:54:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIGAd-000mUm-Ky for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 19:54:43 +0200 Original-Received: from localhost ([::1]:53372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIGAb-00044J-Lt for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 13:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41067) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIB8w-00060h-Dp for emacs-devel@gnu.org; Wed, 09 Oct 2019 08:32:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iIB8v-0002s3-Bt; Wed, 09 Oct 2019 08:32:37 -0400 Original-Received: from [176.228.60.248] (port=1243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iIB8u-00022t-KC; Wed, 09 Oct 2019 08:32:37 -0400 In-reply-to: <20191009120534.ud6st2xvrv3rv6iy@Ergus> (message from Ergus on Wed, 9 Oct 2019 14:05:34 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240774 Archived-At: Martin, can you please explain the rationale behind this code in x_change_tool_bar_height (and similar code in the w32 variant)? /* Recalculate toolbar height. */ f->n_tool_bar_rows = 0; if (old_height == 0 && (!f->after_make_frame || NILP (frame_inhibit_implied_resize) || (CONSP (frame_inhibit_implied_resize) && NILP (Fmemq (Qtool_bar_lines, frame_inhibit_implied_resize))))) f->tool_bar_redisplayed = f->tool_bar_resized = false; adjust_frame_size (f, -1, -1, ((!f->tool_bar_resized && (NILP (fullscreen = get_frame_param (f, Qfullscreen)) || EQ (fullscreen, Qfullwidth))) ? 1 : (old_height == 0 || height == 0) ? 2 : 4), false, Qtool_bar_lines); f->tool_bar_resized = f->tool_bar_redisplayed; Here are the questions that I couldn't answer myself: . why the tool_bar_resized flag is reset when frame-inhibit-implied-resize is nil, i.e. implied resizing is _NOT_ inhibited? shouldn't it be the other way around? . the above resets the tool_bar_redisplayed flag, then uses it after the call to adjust_frame_size; but nothing in that call can ever change the value of the tool_bar_redisplayed flag, so I don't understand what the code tries to accomplish. . which code is supposed to reset the tool_bar_resized flag? AFAICT, once set, it stays set, at least in "emacs -Q". Did I miss something? Same question regarding the tool_bar_redisplayed flag. The real motivation for these questions is the problem with redisplaying the frame when tab-bar is turned on by "C-x 6 f", but since the tab-bar code was simply copied from the tool-bar code, I find myself wondering about the latter, and hope you can show me the light there. TIA