From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: jit-lock-antiblink-grace Date: Sat, 12 Oct 2019 18:57:23 +0300 Message-ID: <83pnj2lzx8.fsf@gnu.org> References: <834l0enw8c.fsf@gnu.org> <83y2xqm6m4.fsf@gnu.org> <83tv8em48z.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38853"; mail-complaints-to="usenet@blaine.gmane.org" Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 12 17:57:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJJm5-0009y2-Ao for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 17:57:45 +0200 Original-Received: from localhost ([::1]:34448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJJm3-0000sj-8J for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 11:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55275) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJJlu-0000sH-Pj for emacs-devel@gnu.org; Sat, 12 Oct 2019 11:57:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJJlu-0006i2-Eq; Sat, 12 Oct 2019 11:57:34 -0400 Original-Received: from [176.228.60.248] (port=2159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJJlt-0006Fx-BQ; Sat, 12 Oct 2019 11:57:34 -0400 In-reply-to: (message from Stefan Monnier on Sat, 12 Oct 2019 10:34:44 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240925 Archived-At: > From: Stefan Monnier > Cc: joaotavora@gmail.com, emacs-devel@gnu.org > Date: Sat, 12 Oct 2019 10:34:44 -0400 > > >> The only case where we don't is when we can't keep up with the input > >> events in which case we skip redisplay, but that's the case where > >> we're *already* too slow. > > > > My point is that post-command-hook might be called more often than > > once per redisplay cycle, and I think we agree on that, right? > > Yes, but only if we can't keep up (i.e. if the event queue is already > non-empty when we're done processing an event). So whether something is > done in redisplay or in post-command-hook doesn't affect the repeat-rate > threshold where we start skipping redisplay: it only affect how much > speed we gain by skipping redisplay (i.e. how quickly we can recover). What is the purpose of this argument? Do you agree that adding too much to post-command-hook should be avoided? If you do, then let's not split hair about the rest, okay? > > I'm not saying this is not a useful feature, and I'm not objecting to > > its inclusion. I'm asking why do we need to turn it on by default > > right when we introduce it. > > Because I think it offers the behavior 99% of the users will want > (modulo bugs). You are entitled to your opinion, and I'm entitled to mine. > Everyone I ever talked to about this agreed that the current > behavior is somewhat annoying Here, you are talking to someone who is much more annoyed by the sluggishness of our movement commands than by an occasional "flashes" of incorrect fontification when I'm in the process of modifying code. So I guess not "everyone" finds this annoying enough. > > Font lock does slow down Emacs, so calling it in more cases/places > > will do so as well. > > AFAICT the code doesn't call font-lock. It adds a timer that does.