From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049. Date: Thu, 14 Nov 2019 15:49:07 +0200 Message-ID: <83pnhu6018.fsf@gnu.org> References: <20191109144026.20810.76129@vcs0.savannah.gnu.org> <20191109144027.DDC3720927@vcs0.savannah.gnu.org> <38328d99-23c8-7ba7-a23d-e70ac0aab67a@yandex.ru> <20191111203445.GA5135@ACM> <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> <20191113211936.GB4942@ACM> <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="82894"; mail-complaints-to="usenet@blaine.gmane.org" Cc: acm@muc.de, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 14:49:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVFV7-000LMO-0p for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 14:49:33 +0100 Original-Received: from localhost ([::1]:57762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVFV5-0002N9-NU for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 08:49:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVFUy-0002Lw-2R for emacs-devel@gnu.org; Thu, 14 Nov 2019 08:49:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVFUx-00071h-Da; Thu, 14 Nov 2019 08:49:23 -0500 Original-Received: from [176.228.60.248] (port=3366 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVFUw-00047o-Sr; Thu, 14 Nov 2019 08:49:23 -0500 In-reply-to: <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> (message from Dmitry Gutov on Thu, 14 Nov 2019 00:33:33 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242155 Archived-At: > From: Dmitry Gutov > Date: Thu, 14 Nov 2019 00:33:33 +0200 > Cc: emacs-devel@gnu.org > > Very interesting, thank you. I wonder if the patch below would fix it as > well. Though, if course, that can't account for all possible uses of > vertical-motion inside a narrowed buffer. > > diff --git a/lisp/reposition.el b/lisp/reposition.el > index 22f9986efb..131e595858 100644 > --- a/lisp/reposition.el > +++ b/lisp/reposition.el > @@ -172,6 +172,8 @@ reposition-window > > ;; Return number of screen lines between START and END. > (defun repos-count-screen-lines (start end) > + ;; Make sure jit-lock doesn't have to run in a narrowed context. > + (font-lock-ensure start end) Isn't this a kludge of sorts? We want CC mode not to fail to fontify if it's called in a narrowed context, regardless of how that happened, and you seem to be fixing just this particular situation? The actual problem is much more general, AFAIU.