From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5ee43ba0df causing display hangs? Date: Wed, 11 Dec 2019 19:14:06 +0200 Message-ID: <83pnguaiox.fsf@gnu.org> References: <87k178gu5g.fsf@wavexx.thregr.org> <83sglwdoc0.fsf@gnu.org> <83pnh0dmvl.fsf@gnu.org> <87pnh0ezhx.fsf@wavexx.thregr.org> <83muc4djwg.fsf@gnu.org> <878snn3fi0.fsf@wavexx.thregr.org> <837e36errp.fsf@gnu.org> <874kyau7mi.fsf@wavexx.thregr.org> <834kyaeowc.fsf@gnu.org> <87v9qola7f.fsf@wavexx.thregr.org> <19062F8F-0969-4ADD-87E5-F67443D376F2@gnu.org> <87v9qnayaz.fsf@wavexx.thregr.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245647"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 11 18:28:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1if5ms-0011kR-Al for ged-emacs-devel@m.gmane.org; Wed, 11 Dec 2019 18:28:34 +0100 Original-Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5mr-0004wo-0a for ged-emacs-devel@m.gmane.org; Wed, 11 Dec 2019 12:28:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47880) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5Z2-0006fu-Ee for emacs-devel@gnu.org; Wed, 11 Dec 2019 12:14:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1if5Z1-0007df-WB; Wed, 11 Dec 2019 12:14:16 -0500 Original-Received: from [176.228.60.248] (port=4293 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1if5Z1-0007TW-Ic; Wed, 11 Dec 2019 12:14:15 -0500 In-reply-to: <87v9qnayaz.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Wed, 11 Dec 2019 12:36:52 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243304 Archived-At: > From: Yuri D'Elia > Cc: emacs-devel@gnu.org > Date: Wed, 11 Dec 2019 12:36:52 +0100 > > gnus-header-content inherits indeed a redundant quote: > > ((:family . unspecified) (:foundry . unspecified) (:width . unspecified) > (:height . unspecified) (:weight . unspecified) (:slant . unspecified) > (:underline . unspecified) (:overline . unspecified) (:extend . unspecified) > (:strike-through . unspecified) (:box . unspecified) (:inverse-video . unspecified) > (:foreground . unspecified) (:background . unspecified) (:stipple . unspecified) > (:inherit quote mu4e-header-value-face)) > > I've found where I had this incorrectly set. After removing the quote > the loop properly terminates. > > So it looks like a good fix would be first to ensure a failure in the > inner for loop in get_lface_attributes properly terminates. And also to > check for an explicit face symbol in inherit? OK, so it's indeed a cockpit error. I installed the change you proposed to terminate the outer loop in face_inherited_attr in such cases. As for the other part, I'm not sure what you are proposing -- what do you mean by "check for an explicit face symbol in inherit"? Thanks.