From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: pipcet@gmail.com, emacs-devel@gnu.org
Subject: Re: master 64e25cd: More robust NS hex colour string parsing
Date: Fri, 12 Jun 2020 22:11:10 +0300 [thread overview]
Message-ID: <83pna43xrl.fsf@gnu.org> (raw)
In-Reply-To: <3C92A091-F389-4179-B2F0-B3AA5ABD6CCE@acm.org> (message from Mattias Engdegård on Fri, 12 Jun 2020 21:00:10 +0200)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Fri, 12 Jun 2020 21:00:10 +0200
> Cc: pipcet@gmail.com, emacs-devel@gnu.org
>
> 12 juni 2020 kl. 19.33 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > Were the 4 versions identical or different? If the latter, what were
> > the differences, and which of the features that call them will from
> > now on behave differently?
>
> They were not semantically equivalent but clearly intended to be. Only the X and Windows versions accepted the rgbi: format; most if not all had bad error-checking (simple typos silently giving nonsense values), and the Windows version appears to have normalised incorrectly in some cases (this is from reading the code with no Windows machine handy).
>
> The new code should parse a superset of what the old code did, detect more mistakes, and be as accurate as we can make it.
Thanks, but I don't think I understand the answer well enough to make
up my mind regarding the proposed code. The error checking aside, are
the return values of the original code the same as of the proposed
unified code? If not, which of the 4 current versions differ, and
how?
next prev parent reply other threads:[~2020-06-12 19:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200608120746.30163.87810@vcs0.savannah.gnu.org>
[not found] ` <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org>
2020-06-08 12:26 ` master 64e25cd: More robust NS hex colour string parsing Pip Cet
2020-06-08 16:15 ` Mattias Engdegård
2020-06-12 16:59 ` Mattias Engdegård
2020-06-12 17:33 ` Eli Zaretskii
2020-06-12 19:00 ` Mattias Engdegård
2020-06-12 19:11 ` Eli Zaretskii [this message]
2020-06-12 19:25 ` Eli Zaretskii
2020-06-13 10:17 ` Mattias Engdegård
2020-06-13 11:59 ` Eli Zaretskii
2020-06-13 15:39 ` Mattias Engdegård
2020-06-13 15:58 ` Eli Zaretskii
2020-06-13 16:44 ` Mattias Engdegård
2020-06-13 17:09 ` Eli Zaretskii
2020-06-13 17:29 ` Mattias Engdegård
2020-06-13 17:35 ` Eli Zaretskii
2020-06-13 17:56 ` Mattias Engdegård
2020-06-13 18:40 ` Eli Zaretskii
2020-06-15 8:31 ` Mattias Engdegård
2020-06-21 7:48 ` Mattias Engdegård
2020-06-21 14:59 ` Eli Zaretskii
2020-06-21 19:23 ` Mattias Engdegård
2020-06-13 19:15 ` Basil L. Contovounesios
2020-06-12 19:15 ` Pip Cet
2020-06-13 10:40 ` Mattias Engdegård
2020-06-12 18:33 ` Basil L. Contovounesios
2020-06-13 17:52 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pna43xrl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).