From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Wed, 30 Dec 2020 05:33:03 +0200 Message-ID: <83pn2shssw.fsf@gnu.org> References: <835z4qnhyx.fsf@gnu.org> <83y2hklqhg.fsf@gnu.org> <83y2hgiimt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 30 04:33:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuSFB-00087Z-SW for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Dec 2020 04:33:49 +0100 Original-Received: from localhost ([::1]:49942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuSFA-0005q6-VK for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Dec 2020 22:33:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuSEX-0005PU-9c for emacs-devel@gnu.org; Tue, 29 Dec 2020 22:33:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44199) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuSEW-0001s5-HG; Tue, 29 Dec 2020 22:33:09 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1659 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuSEV-0007P6-BX; Tue, 29 Dec 2020 22:33:08 -0500 In-Reply-To: (message from Philipp Stephani on Tue, 29 Dec 2020 22:36:40 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262098 Archived-At: > From: Philipp Stephani > Date: Tue, 29 Dec 2020 22:36:40 +0100 > Cc: Emacs developers > > > CC getdtablesize.o > > getdtablesize.c:58:1: warning: no previous prototype for 'getdtablesize' [-Wmissing-prototypes] > > 58 | getdtablesize (void) > > | ^~~~~~~~~~~~~ > > Ah, I guess this is because the MinGW build excludes Gnulib's unistd.h > etc. So for now it looks like we do have to exclude the spawn modules > from the Windows build (unless we can include the POSIX headers from > Gnulib). The Gnulib unistd.h caused trouble in the MinGW build, so we disabled it long ago. On the trunk, we don't compile getdtablesize.c, either, and I don't see why we would need to. (It's not that we always exclude headers from Gnulib on Windows, we only do that with headers that cause trouble.)