From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b99ec5d 3/3: Work around __has_attribute bug in clang 3.4 Date: Sat, 23 Jan 2021 19:27:02 +0200 Message-ID: <83pn1v4l95.fsf@gnu.org> References: <20210122200300.770.63187@vcs0.savannah.gnu.org> <20210122200304.8BBE820A10@vcs0.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29763"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, rgm@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 18:27:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Mha-0007dl-Ms for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 18:27:58 +0100 Original-Received: from localhost ([::1]:51550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3MhZ-0001Gv-Ak for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 12:27:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Mgi-0000q6-Uc for emacs-devel@gnu.org; Sat, 23 Jan 2021 12:27:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45058) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Mgh-00081b-2v; Sat, 23 Jan 2021 12:27:03 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4869 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l3Mgd-0007z6-Ka; Sat, 23 Jan 2021 12:27:01 -0500 In-Reply-To: (message from Philipp Stephani on Sat, 23 Jan 2021 17:32:24 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263305 Archived-At: > From: Philipp Stephani > Date: Sat, 23 Jan 2021 17:32:24 +0100 > Cc: Glenn Morris , Paul Eggert , > Emacs developers > > > Apple's clang seems to come with a builtin > > > > #define __nonnull _Nonnull > > > > which clashes with the the one in lib/cdefs.h. Perhaps we should call it something else. > > Gnulib should avoid identifiers starting with an underscore, as they > are reserved for the implementation. I don't think it can, at least not in general, because Gnulib replaces some implementations, and this is a kind-of implementation itself. The rule that you cite is for applications, not for system libraries.