From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Patch to add tab bar support to the nextstep port
Date: Fri, 15 Oct 2021 22:05:15 +0300
Message-ID: <83pms6hzx0.fsf@gnu.org>
References: <87h7dkped6.fsf.ref@yahoo.com> <87h7dkped6.fsf@yahoo.com>
 <87bl3spe74.fsf@yahoo.com> <YWnDTTSp0k6EHmPt@idiocy.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="30816"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: luangruo@yahoo.com, emacs-devel@gnu.org
To: Alan Third <alan@idiocy.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 21:12:29 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mbSd3-0007rH-Cs
	for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 21:12:29 +0200
Original-Received: from localhost ([::1]:51202 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mbSd2-0001l4-7b
	for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 15:12:28 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49106)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mbSWm-0005tl-5Y
 for emacs-devel@gnu.org; Fri, 15 Oct 2021 15:06:00 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42614)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mbSWk-0002dI-Cs; Fri, 15 Oct 2021 15:05:58 -0400
Original-Received: from [87.69.77.57] (port=4078 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mbSW4-0006oP-PK; Fri, 15 Oct 2021 15:05:27 -0400
In-Reply-To: <YWnDTTSp0k6EHmPt@idiocy.org> (message from Alan Third on Fri, 15
 Oct 2021 19:07:09 +0100)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:277138
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/277138>

> Date: Fri, 15 Oct 2021 19:07:09 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: emacs-devel@gnu.org
> 
> On Thu, Oct 14, 2021 at 09:50:23AM +0800, Po Lu wrote:
> > 
> > Never mind that, I'm still learning my way around Git.
> > Here's the correct version of that patch:
> 
> Looks good to me.
> 
> As for whether it can go into Emacs 28 that's up to Eli and Lars. I
> don't see anything particularly controversial in there.

It's fine with me to install this on the release branch, if the code
looks fine to you.  After all, this code is only used when the user
turns on tab-bar-mode, which otherwise does nothing useful, right?