unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com
Subject: Re: Semantic hl-line-mode (was: ELPA: add lin.el)
Date: Wed, 10 Nov 2021 16:33:08 +0200	[thread overview]
Message-ID: <83pmr82i8r.fsf@gnu.org> (raw)
In-Reply-To: <87y25whzcm.fsf@protesilaos.com> (message from Protesilaos Stavrou on Wed, 10 Nov 2021 16:14:33 +0200)

> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Wed, 10 Nov 2021 16:14:33 +0200
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> Following your advice, I have prepared a patch for hl-line.el.  Please
> find it attached.  Feel welcome to make changes.

Thanks.

> +** Semantic hl-line-mode
> +It is now possible to differentiate between two types of highlighting:
> +(i) line selection, or (ii) simple line highlight.  The former is
> +appropriate for interfaces that operate on the current line (e.g. a
> +listing of email threads), while the latter helps identify the point
> +on the vertical axis.
> +
> +Major modes can register themselves as having a selection-based
> +interface by setting the local variable 'hl-line-select-line-style' to
> +non-nil.  In that case, they will use the new 'hl-line-selection'
> +face.
> +
> +The user option 'hl-line-selection-ui' can be set to nil to disable
> +this feature altogether, meaning that only the 'hl-line-face' will be
> +applied.
> +
> +Users or theme developers may, in turn, choose to make the 'hl-line'
> +face more subtle while allowing a more prominent style where it is
> +really needed via the 'hl-line-selection' face.

I've read this text and the other documentation in the patch, and I
still don't understand what this does and how it differs from the
default operation of hl-line.  You describe quite a lot of
implementation-elated details, but very little information that can
help the user decide whether he or she wants this option.  I think one
problem (but not the only one) is that you use "selection", which is
an overloaded term (you definitely do NOT mean X selections, right?).

Could you please rework the documentation so that it becomes more
user-facing?



  reply	other threads:[~2021-11-10 14:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 19:29 ELPA: add lin.el Protesilaos Stavrou
2021-11-05 20:28 ` Stefan Kangas
2021-11-06  4:55   ` Protesilaos Stavrou
2021-11-06  6:12     ` Stefan Kangas
2021-11-09 19:46 ` Protesilaos Stavrou
2021-11-09 20:15   ` Stefan Monnier
2021-11-09 20:38     ` Protesilaos Stavrou
2021-11-10 14:14     ` Semantic hl-line-mode (was: ELPA: add lin.el) Protesilaos Stavrou
2021-11-10 14:33       ` Eli Zaretskii [this message]
2021-11-10 14:53         ` Stefan Kangas
2021-11-10 16:53           ` Protesilaos Stavrou
2021-11-13 15:06             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pmr82i8r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).