From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS Date: Sat, 27 Nov 2021 13:32:18 +0200 Message-ID: <83pmqlzvel.fsf@gnu.org> References: <20211125030922.2353.1129@vcs0.savannah.gnu.org> <871r34h6pi.fsf@gmail.com> <87fsrkzfq1.fsf@yahoo.com> <83tug05whz.fsf@gnu.org> <87tufzycli.fsf@yahoo.com> <837dcv4e79.fsf@gnu.org> <87wnkvflk7.fsf@yahoo.com> <83zgpr2uvr.fsf@gnu.org> <87fsrjfeb1.fsf@yahoo.com> <83r1b32lvr.fsf@gnu.org> <877dcvf8ec.fsf@yahoo.com> <831r323lgs.fsf@gnu.org> <87v90ecvoa.fsf@yahoo.com> <83lf1a1651.fsf@gnu.org> <875ysecd75.fsf@yahoo.com> <83fsri13k0.fsf@gnu.org> <87wnkuax4q.fsf@yahoo.com> <83y259zxgz.fsf@gnu.org> <87sfvhc1hp.fsf@yahoo.com> <83tufxzwq9.fsf@gnu.org> <87k0gtc0z5.fsf@yahoo.com> <87fsrhc0lz.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16197"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 12:33:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqvwy-00043K-N5 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 12:33:01 +0100 Original-Received: from localhost ([::1]:58522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqvwx-0003oJ-6Q for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 06:32:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvwB-0002zR-Fj for emacs-devel@gnu.org; Sat, 27 Nov 2021 06:32:11 -0500 Original-Received: from [2001:470:142:3::e] (port=55808 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvwB-0006do-1q; Sat, 27 Nov 2021 06:32:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qWsNZUbL8SwONfxpcF3E+B5d6oOyVgVNJpnlEEKYDao=; b=E9aQ+AVPzw3k DuNdJEgTgA0R+UPgSgSL92NaSPFqTRnK2lLGlkVqnjh47OfPGb117YwjFkELmixP2tfbBj48uoYCh /HnT64wVwvsj/XTEDm1Uo3x2D2+xRYhUa+U9HnMNWB8/1pTb7VKnQIBCX/XfISfOLx2VHjrG4rSHc QSJnW3mQf/CyoxSDzEPWVwibuX2fdHFxyroqDjzZSRzglmxSPQYzw5ezX5D5ge1dN/l0fo7oRWFUN 290RaK+J/8NgDiSnsyNz79HLr6+Mx0opHt+x760/8c+43TGJ983G03uGW2d8oLY4qHN1QhthaxAU0 ql0mNAA4mjboIZkRjK5cqw==; Original-Received: from [87.69.77.57] (port=3647 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvwA-0007zD-OI; Sat, 27 Nov 2021 06:32:11 -0500 In-Reply-To: <87fsrhc0lz.fsf@yahoo.com> (message from Po Lu on Sat, 27 Nov 2021 19:13:44 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280327 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Sat, 27 Nov 2021 19:13:44 +0800 > > @cindex @code{wheel-up} event > @cindex @code{wheel-down} event > @item (wheel-up @var{position} @var{clicks} @var{lines} @var{pixel-delta}) > @itemx (wheel-down @var{position}) > These kinds of event are generated by moving a mouse wheel. The > @var{position} element is a mouse position list (@pxref{Click > Events}), specifying the position of the mouse cursor when the event > occurred. > > @var{clicks}, if present, is the number of times in quick succession > the wheel has been moved. By "if present", do you mean it can be absent, or do you mean it can be nil? If the latter, then "present" is not the right word. Also, can this CLICKS member really be anything but 1 when the wheel is used? > @var{lines}, if present, is the number of screen lines that should > be scrolled. @var{pixel-delta}, if present, is a pair of the form > @w{@code{(@var{x} . @var{y})}}, where @var{x} and @var{y} are the > number of pixels to scroll by in each axis. > > WDYT? Also, it seems that `lines' is only generated by the NS port, so > it should perhaps be worthwhile to mention that as well? Doesn't "if present" already handle that? (Assuming you meant it can be nil.) Otherwise LGTM, thanks.