From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Re: Early backtrace. Date: Mon, 31 Jan 2022 14:42:24 +0200 Message-ID: <83pmo884b3.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23238"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 31 14:33:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEWod-0005qy-9m for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Jan 2022 14:33:55 +0100 Original-Received: from localhost ([::1]:60084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEWob-0000ZK-H0 for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Jan 2022 08:33:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEW0s-0007e0-7k for emacs-devel@gnu.org; Mon, 31 Jan 2022 07:42:49 -0500 Original-Received: from [2001:470:142:3::e] (port=43500 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEW0q-0003Mj-7I; Mon, 31 Jan 2022 07:42:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=B5T+SC5nZzIquMUYUfprY01kuElb4YAJR5tBgxplqg8=; b=TtfDmjcvjBiN UYniCh1fWicaeMgyhS6DCG3pW9XV8CrEgL9pdLXoz8A1mwJdVxswkyW48NA3rZA+H/T2ZphDy5yEO yXtq6LBatkCVuCLNn0GT0X5mjey3YsgWXqZKuBPkjH4//LbwzsqOhWvJlV9WuMmQeE6gwvj5pYAhr roBqeQOraLU4A+PC+f6umoUqaiOW7Jixv3rgBCJLa11o+fL2AHdNIuZREqWQQEyglw0xl6XAseuOW p5y4TRFybf7RB8coDY8TAAn3qXand7xY+iB/XOwiIZmEBhEqspQbTqniYSS1gQHPWak6WXaPvu+OD Ti37Glu9UZU9PcTzPwspPg==; Original-Received: from [87.69.77.57] (port=2596 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEW0p-0000Ze-Ar; Mon, 31 Jan 2022 07:42:27 -0500 In-Reply-To: (message from Philipp Stephani on Mon, 31 Jan 2022 10:30:35 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285666 Archived-At: > From: Philipp Stephani > Date: Mon, 31 Jan 2022 10:30:35 +0100 > Cc: Stefan Monnier , > Emacs developers > > Am So., 30. Jan. 2022 um 12:08 Uhr schrieb Alan Mackenzie : > > > > It also fixes a bug in signal_or_quit (eval.c) where previously there > > was: > > > > specbind (Vdebugger, Qdebug); > > > > , which had the effect of binding the contents of Vdebugger (namely > > Qdebug) to itself. Correct would have been: > > > > specbind (Qdebugger, Qdebug); > > > > , binding the symbol Qdebugger to Qdebug. > > > > > > Good find, thanks. Independent of the rest of the patch, should we > install this one-character fix on the release branch? Yes, please. > Maybe that would even make commit > 07edc28bdbfeeaeb1008b4fe21bfda586feae562 unnecessary? (Haven't > checked, though.) I wouldn't touch that part, as it cannot possibly do any harm.