From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add the Kaithi script to Emacs Date: Sat, 07 May 2022 09:01:02 +0300 Message-ID: <83pmkpzxsx.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13199"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?4KS44KSu4KWA4KSwIOCkuOCkv+CkguCkuSBTYW1lZXIgU2luZ2g=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 07 08:04:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnDXs-0003Dl-Im for ged-emacs-devel@m.gmane-mx.org; Sat, 07 May 2022 08:04:00 +0200 Original-Received: from localhost ([::1]:37598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnDXq-0008R5-WE for ged-emacs-devel@m.gmane-mx.org; Sat, 07 May 2022 02:03:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnDVD-0007WR-Ju for emacs-devel@gnu.org; Sat, 07 May 2022 02:01:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnDVD-00053F-BU; Sat, 07 May 2022 02:01:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YId4qyizxIxGmDM0MOCSObI4M/EoUP1z0GUyv4S+nDY=; b=elNqMMiPJ8vPVmqpR68z TwTHIF3C5YSYBqC10olfLSAHjpv28fnvLdv2IlRbhe8AZtIYhDu4w99hRj92WKCAJ+sKqOqekl5bI arzqGFINnaoS/bawDbTgbXDJCvLDjwlpuDna6im81Lb3YGqKLa8ZkqQEIRYpD+f742u68sOIc24Et uodtCKP+s88QNpAw1Jpf3tHfB/yST/x536CoFDL5OSYsxc9d7oAWOKuaH1I2F5S7nC4OgLBznljvU YBHv6uyjPao69Zx/QNVWW4a01INZR3j6ncCU+gT/nh40Kh5i+IOivJl3HwUdYUF6teQnkAD81t9y1 QeL+0Gk0LcKj/w==; Original-Received: from [87.69.77.57] (port=3682 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnDVB-0008E0-JC; Sat, 07 May 2022 02:01:14 -0400 In-Reply-To: (lumarzeli30@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289370 Archived-At: > From: समीर सिंह Sameer Singh > > Date: Sat, 7 May 2022 02:32:06 +0530 > > I have added the Kaithi script this time. > Please check for any mistakes Thanks. > diff --git a/etc/HELLO b/etc/HELLO > index dbbcc0493b..351e2dc4cd 100644 > --- a/etc/HELLO > +++ b/etc/HELLO > @@ -59,6 +59,8 @@ Hindi (हिंदी) नमस्ते / नमस्कार । > Inuktitut (ᐃᓄᒃᑎᑐᑦ) ᐊᐃ > Italian (italiano) Ciao / Buon giorno > Javanese (ꦧꦱꦗꦮꦶ) console.log("ꦲꦭꦺꦴ"); > + > +Kaithi (𑂍𑂶𑂟𑂲) 𑂩𑂰𑂧𑂩𑂰𑂧 The text in parenthesis should be the name of the script spelled in the script itself, followed by a single TAB, and then one or more greetings in language(s) that use(s) the script. Does the above follow this pattern? I see that you used spaces instead of TAB, which is incorrect. > +*** New language environment "Kaithi". > +This language environment supports Kaithi or Kayasthi, which was > +an important writing system of the past mainly used for administrative > +purposes. A new input method, 'kaithi', is provided to type text in Please leave 2 spaces between sentences in documentation, per US English rules we use. > diff --git a/lisp/international/fontset.el b/lisp/international/fontset.el > index 883f08905e..5bfa085b1b 100644 > --- a/lisp/international/fontset.el > +++ b/lisp/international/fontset.el > @@ -232,6 +232,7 @@ font-encoding-charset-alist > (elymaic #x10FE0) > (old-uyghur #x10F70) > (brahmi #x11013 #x11045 #x11052 #x11065) > + (kaithi #x1108D) Is a single character enough to accept a font as having good coverage of Kaithi? If not, you can request more than one, like I did for Brahmi. > @@ -599,6 +600,7 @@ setup-default-fontset > (sinhala ,(font-spec :registry "iso10646-1" :otf '(sinh nil (akhn)))) > (malayalam ,(font-spec :registry "iso10646-1" :otf '(mlm2 nil (akhn))) > ,(font-spec :registry "iso10646-1" :otf '(mlym nil (akhn)))) > + (kaithi ,(font-spec :registry "iso10646-1" :otf '(kthi nil (rphf)))) Is the rphf feature indeed needed for Kaithi? If not, just add kaithi to the list of "simple scripts" that starts around line 736 in fontset.el, and the code there will do the rest. > + (documentation . "\ > +Such languages which used Kaithi script such as Awadhi, Bhojpuri, Magahi and > +Maithili are supported in this language environment.")) "Such languages ... such as" is awkward English; please rephrase this doc string. > + (set-char-table-range composition-function-table > + '(#x110B0 . #x110BA) > + (list (vector > + (concat consonant nukta "?\\(?:" virama consonant nukta "?\\)*\\(?:" virama "\\|" vowel "*" nukta "?" anusvara-candrabindu "?\\)") Please break and reindent this long line to make it more readable. > +("`c" #x200C) ; ZWNJ > +("`C" #x200D) ; ZWJ Are these zero-width characters used for writing in Kaithi? If so, should the composition rules be augmented with some rules that mentions them? At least ZWJ, if it has any role, should probably be mentioned; ZWNJ most probably does its job by just being there and preventing the other composition rules from taking effect. Thanks.