From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Fri, 03 Mar 2023 09:00:44 +0200 Message-ID: <83pm9qco9v.fsf@gnu.org> References: <877h40vb8h.fsf@mail.jurta.org> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> <83wn41fvc9.fsf@gnu.org> <878rggrict.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26764"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 03 08:02:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXzQk-0006lG-U6 for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Mar 2023 08:02:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXzPc-00039j-Jc; Fri, 03 Mar 2023 02:01:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzPa-0002uF-8J for emacs-devel@gnu.org; Fri, 03 Mar 2023 02:01:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzPZ-0005RE-08; Fri, 03 Mar 2023 02:01:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LTMhA+cBWXiImKNDM1prsg0mQW+1zqXduVlHqVyXEBE=; b=ZSMmQ2bBU+Im5wX+MzSN oSDWLQxSNz3hP3OOlsjwRfdXIefiHckWjJRYPVgpJAof8f3hCw9vMT8iQ0ZkYd0REmBsHl5KLixl9 /9knH0VcZYfKGVgK2hR1LendSls35KCAmpbfOEICfoniwwM0DuJNQYhF+V64p6QDrxKBe2pgABWbu EyakmSiKwXM5LJ/Qw+K2bgoBHlUBie8Vgh7lVay6KkxQVAEch5gKHgDDub7/KfEWdMM4xHMc4q5ri dF+YYopIiuQ2zd8XNImwJxWS356qA19oPiNc1XUSriXvc6gvby3h5zqFtjdJ3RuqB+2mqi2mR8ykK hpIQdhcOMLoDlQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzPY-0001PC-4T; Fri, 03 Mar 2023 02:01:00 -0500 In-Reply-To: (message from Jim Porter on Thu, 2 Mar 2023 14:15:49 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303908 Archived-At: > Date: Thu, 2 Mar 2023 14:15:49 -0800 > Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org > From: Jim Porter > > On 3/1/2023 12:22 AM, Robert Pluim wrote: > >>>>>> On Tue, 28 Feb 2023 11:41:41 -0800, Jim Porter said: > > Jim> + ;; When running in a batch session, we can't create a GUI frame. > > > > Itʼs not that we canʼt, itʼs that we shouldnʼt. If we install a SIGIO > > handler and run the test with DISPLAY set, a GUI frame appears > > briefly. > > Well, since we don't have a SIGIO handler (and merely adding one > wouldn't be a useful change, it seems), I'd say "can't" applies for now > at least. :) > > But it would probably make sense to expand this comment to explain > *why*, since it's not as informative as it could be... > > > Jim> + (when noninteractive > > Jim> + (push '(display . nil) parameters)) > > Jim> + > > > > I think that might be better off using `alist-get' + `setf' to avoid > > having two `display' elements in the parameters. > > Would that be safe? Since 'parameters' is an argument, we don't actually > know how it was created or if modifying in-place would be ok. If it were > just a regular quoted list, using 'setf' could cause problems. If this aspect could be an issue, perhaps it is better to implement the change without touching 'parameters' at all? It isn't hard, it just might make the change less elegant and slightly larger.