From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Sat, 22 Apr 2023 09:11:55 +0300 Message-ID: <83pm7w30pg.fsf@gnu.org> References: <5e494275-d253-118a-4a40-86d252285a23@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: john@yates-sheets.org, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 22 08:12:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pq6TY-000AHx-GT for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Apr 2023 08:12:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pq6TF-0007o5-Bs; Sat, 22 Apr 2023 02:11:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq6TD-0007nJ-2j for emacs-devel@gnu.org; Sat, 22 Apr 2023 02:11:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq6TC-0004jo-Ap; Sat, 22 Apr 2023 02:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yZHcw6CqOlG6RlLcu/44feUSRG1CrD9Q8/Lg5Gz1Ngw=; b=FXRyH1XOPcv9 GMiQwA8kJykM2struOp1z2j47eYPBFLEUWjAFWVwq82HIMpcAJyUeyEvMKxpCQYundgb9wg7Bzfv2 R0fxryYNBYLYY7Owu6MznZe7TLIYdtckN/CLKizjk7p91ZNmLBpUFULEL1ZStPzsJczXiDlLguIK3 lw97cdAcN1cY4Lwr8j0r+7A+qMCAiFSD9BKQifd4TUocdhnF7OuVAEN+ppf1KZDE9lTjKi0qJxEgf l822eIZ0gsZrCvPqbIMEAr6NwV+8yqNziFTo2GeEGG09pM8dtU6w1eYHw17CLEG8Rw4g8BKLOUxjZ OA0+2gwiPLwGQrddbtY1AA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq6TB-0004kS-Q0; Sat, 22 Apr 2023 02:11:38 -0400 In-Reply-To: <5e494275-d253-118a-4a40-86d252285a23@gmail.com> (message from Jim Porter on Fri, 21 Apr 2023 10:44:10 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305570 Archived-At: > Date: Fri, 21 Apr 2023 10:44:10 -0700 > From: Jim Porter > Cc: emacs-devel@gnu.org, eliz@gnu.org > > On 4/21/2023 9:44 AM, Jim Porter wrote: > > I tried to be as lenient as possible with the Git hooks so that they > > only catch things that would be a problem for admin/authors.el, though > > there are some small differences regarding multi-line lists of files. > > After thinking about this for a bit, I came up with a way to match > admin/authors.el in the hooks (at least, to the best of my knowledge). > This should mean that the hooks will report exactly the same errors as > admin/authors.el. > > With this patch, there's no restriction on putting a "*" in the first > column of a commit message, so long as that paragraph doesn't also have > a ":" in it (just like admin/authors.el). > > Eli, what do you think? I've run this against the 5000 latest commits > and the results look right (though I haven't looked as thoroughly as > last time). I think the hooks should follow the GNU Standards (which are also our conventions), not their particular expressions in algorithms used by authors.el.