unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: StrawberryTea <look@strawberrytea.xyz>
Cc: emacs-devel@gnu.org
Subject: Re: improving debug output of get-buffer
Date: Wed, 01 Nov 2023 21:38:16 +0200	[thread overview]
Message-ID: <83pm0t8dsn.fsf@gnu.org> (raw)
In-Reply-To: <87wmv1uz53.fsf@strawberrytea.xyz> (message from StrawberryTea on Wed, 01 Nov 2023 13:06:16 -0500)

> From: StrawberryTea <look@strawberrytea.xyz>
> Date: Wed, 01 Nov 2023 13:06:16 -0500
> 
> Following our PR discussion in
> https://github.com/akreisher/eshell-syntax-highlighting/pull/15

Please in the future post the main points of the discussions here.
Some of us don't like (or cannot) accessing GitHub.

> I was wondering if anyone thinks it's a good idea to modify the
> get-buffer C code so that it returns an error like
> "(wrong-type-argument string-or-buffer-p nil)" instead of
> "(wrong-type-argument stringp nil)".

IMO, "wrong-type-argument string-or-buffer-p" is not much better than
what we have now.

The reason why we signal "wrong-type-argument stringp"
is that the argument is almost always a string, because calling the
function with a buffer as an argument is not useful.



  reply	other threads:[~2023-11-01 19:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 18:06 improving debug output of get-buffer StrawberryTea
2023-11-01 19:38 ` Eli Zaretskii [this message]
2023-11-01 20:02   ` StrawberryTea
2023-11-02  6:00     ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2023-11-02 15:11 Rahguzar
2023-11-02 16:44 ` Eli Zaretskii
2023-11-02 16:57   ` Rahguzar
2023-11-04  8:45     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pm0t8dsn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=look@strawberrytea.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).